From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F36CA04FA; Wed, 5 Feb 2020 21:41:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B31DA1D159; Wed, 5 Feb 2020 21:41:10 +0100 (CET) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by dpdk.org (Postfix) with ESMTP id E01121D159 for ; Wed, 5 Feb 2020 21:41:08 +0100 (CET) Received: by mail-lj1-f179.google.com with SMTP id v17so3724269ljg.4 for ; Wed, 05 Feb 2020 12:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zZ7wQCGib2gtKgbB1jexSJHNBfaAiyba5ZIWoJ6Hnm0=; b=PbET15NCkYQf/diyZJsqf7mZmLRB9hApzBmb0nAF1tbxvifasf/h6MHYusgZypd0pg UOv1U8ulYLNENKe5p9KD3h9bNZ0BJp+TNR2hFUXC9gBk4T5hWs22t33lJPk9uI9pzO/P axXDHR/4uHMAEDuD+gWqpJUa/ngpPTlq4RswAF4n7dcI6fvTaYQTrMEwamk3vWNWF3L3 NxAesFNEseFhz7gRzD97gviITKKDZGv8WR1Rkf2+fkTM8gzG9MHoZ6l7frRckSPbYesc G0wu8voM1drbkTHw1BiTUeLChpf1kF6CasUoKwVc/Hn1cRJaloIyfrJtj3IX8JSgNCbZ T3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zZ7wQCGib2gtKgbB1jexSJHNBfaAiyba5ZIWoJ6Hnm0=; b=EVzw8id/SSVl7ocKDqcW/K9rgTqUYHr4/Cg+2CRJotclxxFF7ZbdX92w0WdBHXFQQ5 TN/Z3XG04GkhN2bEwsKliweszpZOkN+7zVURniBbQ8SQ/luSbnFBeJ1nzDwSOgIBPiTC kww8wEW0s6syQ4iF6PF4n2KiOovw2Uf/amAE+bEskcNWrfnBiOi+yAJGujdnZ6xUHbLI hPEu2qky3Fa8+By85RZFOLwueRa5aAO6a9tcOOn68wRltxTeD3gVF9YOPw2PLkVRrB9j bJn4ItLUcDlFS2gHQ+t9WOzFejXSsw96vhJqS7LkmQIVjvYTWAHh75TrIrNFJHtR9owy cCoQ== X-Gm-Message-State: APjAAAWQU2V5IHmEUlcfNQVToWSUQ7NXObXeV1jnGNqMsc3iB4gbT2nT ZfHAhV0r4sdfoEVhAYzLYmg= X-Google-Smtp-Source: APXvYqy/b8na7hVTT2cnL3kOHUwXRrhSx9cDZeLzlpht2PuB1JmZ37Palba5blwPkOwGirB2d85gtQ== X-Received: by 2002:a05:651c:8f:: with SMTP id 15mr21326245ljq.109.1580935268281; Wed, 05 Feb 2020 12:41:08 -0800 (PST) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z13sm277986ljh.21.2020.02.05.12.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 12:41:07 -0800 (PST) Date: Wed, 5 Feb 2020 23:41:05 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org, harini.ramakrishnan@microsoft.com Message-ID: <20200205234105.61ad5c55@Sovereign> In-Reply-To: <20200205143050.GB687@bricha3-MOBL.ger.corp.intel.com> References: <20200131030744.19596-1-dmitry.kozliuk@gmail.com> <2199644.NG923GbCHz@xps> <20200205022138.68c6b854@Sovereign> <12853507.RDIVbhacDa@xps> <20200205143050.GB687@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > +if is_windows > > > > > + # Require platform SDK for Windows 7 and above. > > > > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > > > > > > > Please explain. Why Windows 7 is needed? What this define is doing? > > > > > > Yes, Windows 7 and above is need for already existing code in eal_lcore.c, > > > specifically for GetLogicalProcessorInformation() call. > > > > > > When including , one must define minimum API version the > > > application is compiled against [0]. MSVC and Clang default to the version of > > > platform SDK (that is, maximum supported). MinGW defaults to Windows XP, so > > > this definition must be either in before #include or > > > here. Because other files may include , I'd prefer to have a > > > global definition via compiler command-line. > > > > > > [0]: > > > https://docs.microsoft.com/en-us/windows/win32/WinProg/using-the-windows-headers > > > > OK, thanks. > > Please reword the comment with something like > > "Minimum supported API is Windows 7." > > > For this, as an alternative to putting it as a project argument, you can just > add it to dpdk_conf which means it will end up as a define in the global > rte_build_config.h and so be directly included in each compilation unit > ahead of any other headers. (rte_config.h includes rte_build_config.h) Can you please explain why using dpdk_conf is a better alternative? In lib/meson.build I can see add_project_arguments('_D_GNU_SOURCE', ...), which serves a similar purpose on POSIX systems. Compiler option also makes it impossible to forget or redefine this constant in code by mistake. -- Dmitry Kozlyuk