From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>
Cc: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Olivier Matz <olivier.matz@6wind.com>,
Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support
Date: Thu, 6 Feb 2020 00:21:00 +0300 [thread overview]
Message-ID: <20200206002100.73911706@Sovereign> (raw)
In-Reply-To: <140554c3-df29-82dc-b6f1-70ff624c72ca@microsoft.com>
> I did have to apply your patch "eal/windows: refine public interface" before applying the "MinGW-w64 support" patch set, to avoid the errors caused by including "Windows.h" in rte_os.h. So, I guess this patch needs to come first and then the patchset for mingw can be applied.
The cause of the error you've encountered is case-dependent Linux filesystem.
Existing code includes <Windows.h> (capital W), but MinGW-w64 on Linux
packages <windows.h> (lowercase W). I missed it because Windows.h is manually
symlinked to windows.h on my system. Same goes for <BaseTsd.h>.
Thanks for pointing this out, I think it's more appropriate to change
filename case in this patchset v2, because the need for this change is caused
by adding MinGW cross-compilation capability.
--
Dmitry Kozlyuk
prev parent reply other threads:[~2020-02-05 21:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 3:07 [dpdk-dev] " Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 1/6] eal: introduce portable format attribute Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 2/6] eal: use " Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 3/6] cmdline: " Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson Dmitry Kozlyuk
2020-02-04 22:08 ` Thomas Monjalon
2020-02-04 23:21 ` Dmitry Kozlyuk
2020-02-05 0:41 ` Thomas Monjalon
2020-02-05 14:30 ` Bruce Richardson
2020-02-05 20:41 ` Dmitry Kozlyuk
2020-02-06 10:59 ` Bruce Richardson
2020-02-07 19:27 ` Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 5/6] build: add cross-file for MinGW-w64 Dmitry Kozlyuk
2020-02-04 22:14 ` Thomas Monjalon
2020-02-04 23:23 ` Dmitry Kozlyuk
2020-01-31 3:07 ` [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64 Dmitry Kozlyuk
2020-02-04 22:34 ` Thomas Monjalon
2020-02-04 23:57 ` Dmitry Kozlyuk
2020-02-05 2:20 ` Thomas Monjalon
2020-02-09 21:39 ` Dmitry Kozlyuk
2020-02-17 6:27 ` Dmitry Kozlyuk
2020-04-29 13:57 ` Thomas Monjalon
2020-02-05 1:49 ` [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support Narcisa Ana Maria Vasile
2020-02-05 5:43 ` Dmitry Kozlyuk
2020-02-05 9:26 ` David Marchand
2020-02-05 20:59 ` Dmitry Kozlyuk
2020-02-05 21:02 ` Narcisa Ana Maria Vasile
2020-02-05 21:21 ` Dmitry Kozlyuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206002100.73911706@Sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).