From: Itsuro Oda <oda@valinux.co.jp>
To: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, anatoly.burakov@intel.com
Cc: stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3 4/4] net/vhost: remove an unused member
Date: Thu, 6 Feb 2020 10:39:36 +0900 [thread overview]
Message-ID: <20200206013936.11119-5-oda@valinux.co.jp> (raw)
In-Reply-To: <20200206013936.11119-1-oda@valinux.co.jp>
This patch removes an unused member from pmd_internal.
Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/net/vhost/rte_eth_vhost.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 307de2c68..90263ae77 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -95,7 +95,6 @@ struct vhost_queue {
struct pmd_internal {
rte_atomic32_t dev_attached;
- char *dev_name;
char *iface_name;
uint64_t flags;
uint64_t disable_flags;
@@ -1073,7 +1072,6 @@ eth_dev_close(struct rte_eth_dev *dev)
for (i = 0; i < dev->data->nb_tx_queues; i++)
rte_free(dev->data->tx_queues[i]);
- free(internal->dev_name);
rte_free(internal->iface_name);
rte_free(internal);
@@ -1307,9 +1305,6 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
* - and point eth_dev structure to new eth_dev_data structure
*/
internal = eth_dev->data->dev_private;
- internal->dev_name = strdup(name);
- if (internal->dev_name == NULL)
- goto error;
internal->iface_name = rte_malloc_socket(name, strlen(iface_name) + 1,
0, numa_node);
if (internal->iface_name == NULL)
@@ -1335,10 +1330,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
return 0;
error:
- if (internal) {
+ if (internal)
rte_free(internal->iface_name);
- free(internal->dev_name);
- }
rte_eth_dev_release_port(eth_dev);
return -1;
--
2.17.0
next prev parent reply other threads:[~2020-02-06 1:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 6:25 [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes oda
2020-01-08 6:25 ` [dpdk-dev] [PATCH 1/4] net/vhost: remove an unused member oda
2020-01-08 6:25 ` [dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap oda
2020-01-08 6:25 ` [dpdk-dev] [PATCH 3/4] net/vhost: delay vhost driver setup oda
2020-01-08 6:25 ` [dpdk-dev] [PATCH 4/4] net/vhost: make secondary probe complete oda
2020-01-08 6:38 ` [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes Itsuro ODA
2020-01-08 23:22 ` Itsuro Oda
2020-01-08 23:22 ` [dpdk-dev] [PATCH 1/4] net/vhost: remove an unused member Itsuro Oda
2020-02-04 17:56 ` Maxime Coquelin
2020-01-08 23:22 ` [dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap Itsuro Oda
2020-02-04 17:59 ` Maxime Coquelin
2020-01-08 23:22 ` [dpdk-dev] [PATCH 3/4] net/vhost: delay vhost driver setup Itsuro Oda
2020-02-04 18:04 ` Maxime Coquelin
2020-01-08 23:22 ` [dpdk-dev] [PATCH 4/4] net/vhost: make secondary probe complete Itsuro Oda
2020-02-04 18:08 ` Maxime Coquelin
2020-01-20 2:17 ` [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes Itsuro ODA
2020-02-04 17:54 ` Maxime Coquelin
2020-02-04 22:19 ` Itsuro ODA
2020-02-06 1:39 ` [dpdk-dev] [PATCH v3 " Itsuro Oda
2020-02-06 1:39 ` [dpdk-dev] [PATCH v3 1/4] net/vhost: allocate interface name from heap Itsuro Oda
2020-02-06 1:39 ` [dpdk-dev] [PATCH v3 2/4] net/vhost: delay vhost driver setup Itsuro Oda
2020-02-18 8:50 ` Wang, Yinan
2020-02-18 10:42 ` Maxime Coquelin
2020-02-06 1:39 ` [dpdk-dev] [PATCH v3 3/4] net/vhost: make secondary probe complete Itsuro Oda
2020-02-06 1:39 ` Itsuro Oda [this message]
2020-02-06 14:19 ` [dpdk-dev] [PATCH v3 0/4] make vhost PMD available for secondary processes Maxime Coquelin
2020-02-13 16:29 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206013936.11119-5-oda@valinux.co.jp \
--to=oda@valinux.co.jp \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).