From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21F95A04FA; Thu, 6 Feb 2020 02:39:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A23B1C243; Thu, 6 Feb 2020 02:39:41 +0100 (CET) Received: from valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by dpdk.org (Postfix) with ESMTP id ED92B1C1FF; Thu, 6 Feb 2020 02:39:37 +0100 (CET) Received: by valinux.co.jp (Postfix, from userid 1000) id DEAA62409CF; Thu, 6 Feb 2020 10:39:36 +0900 (JST) From: Itsuro Oda To: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, anatoly.burakov@intel.com Cc: stable@dpdk.org Date: Thu, 6 Feb 2020 10:39:36 +0900 Message-Id: <20200206013936.11119-5-oda@valinux.co.jp> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200206013936.11119-1-oda@valinux.co.jp> References: <20200108062510.3478-1-oda@valinux.co.jp> <20200206013936.11119-1-oda@valinux.co.jp> Subject: [dpdk-dev] [PATCH v3 4/4] net/vhost: remove an unused member X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes an unused member from pmd_internal. Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 307de2c68..90263ae77 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -95,7 +95,6 @@ struct vhost_queue { struct pmd_internal { rte_atomic32_t dev_attached; - char *dev_name; char *iface_name; uint64_t flags; uint64_t disable_flags; @@ -1073,7 +1072,6 @@ eth_dev_close(struct rte_eth_dev *dev) for (i = 0; i < dev->data->nb_tx_queues; i++) rte_free(dev->data->tx_queues[i]); - free(internal->dev_name); rte_free(internal->iface_name); rte_free(internal); @@ -1307,9 +1305,6 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, * - and point eth_dev structure to new eth_dev_data structure */ internal = eth_dev->data->dev_private; - internal->dev_name = strdup(name); - if (internal->dev_name == NULL) - goto error; internal->iface_name = rte_malloc_socket(name, strlen(iface_name) + 1, 0, numa_node); if (internal->iface_name == NULL) @@ -1335,10 +1330,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, return 0; error: - if (internal) { + if (internal) rte_free(internal->iface_name); - free(internal->dev_name); - } rte_eth_dev_release_port(eth_dev); return -1; -- 2.17.0