From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82FB5A04FA; Thu, 6 Feb 2020 09:17:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EC111C045; Thu, 6 Feb 2020 09:17:29 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 9DF111C044 for ; Thu, 6 Feb 2020 09:17:28 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id z7so5939662wrl.13 for ; Thu, 06 Feb 2020 00:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1AdUvUq+kGmL4PwKW44pbJ2soIsxVDe6PAYX0QYFBgE=; b=EkxkApOpqLS0cW80zaQK3tJ2Mc/s2sZfLjQa+FZdFpcW+Aav4fKHWS64gtz/E8eqin 6m56lvZ/RZiUge7ugsVRm2KoDlYZkx6zUOfJftQNTMYVrtWz8ZhJtKTZ9lOWhow466Qd LhJfaRWtyI/SrEUZjVe0dXZmf1ooknCuWasiCuVKbLa1albqxXiv7s56vifU8/Zvafdc ENQdII6XGWTQyW22OU1Pu8aJOheOGiwjkWf0hVBIc/DCnB59bgx6iXvj1V9/Ph8MIOn9 mH3ucer+7yflUBbaScQlHXK1hXkIzXmJdsZ9UsA27yCH8lP5Us3VU9oH9UyAvPX05FlJ 8aVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1AdUvUq+kGmL4PwKW44pbJ2soIsxVDe6PAYX0QYFBgE=; b=AsG4I8LM4Fifl+LbbeNRhdb2QcFLw0MZedEu4cDtFBC8VhhGD1ls9V6LdGmXjjACVs IHhWVnQypPULmxMMjNWcd7vTRzastivHFbWMy9yqoNZewKlpoXwvgpiwx1VOZSWMPXfY yREOZ7vZksyFjEa7k1WcQG8LqZXxI14VZZpoWOLgsVG7XVVzDCDIJHHRw4yf4w6JRAzK 9nDv1aasBYarDAgqxs5vCMXtwUHe5Z6BtpYb5GpuJ3zoeJnnJnUq5JLde4zCEr+uELfT WsBgrwny+ZFFq8CZ3/paTtFqvHvmbDclJpJmbrZcVY5jFNM9v3LEAv6L4UoU65Ha0RSA tJmg== X-Gm-Message-State: APjAAAWnLwe2IufKUPt8UijSG3mI2WCnCy/ad50+15PxwsrZQSg5KMAt 0mvZIejRuOxzqqVlQlPogo+siQ== X-Google-Smtp-Source: APXvYqzLgWCo4s93nlsrRIWdtmQcblbIf044nCcMQjFyRIqLYMEgQWdSvuQTG165f9sQ2kfZfyVSIw== X-Received: by 2002:a5d:528e:: with SMTP id c14mr2466505wrv.308.1580977048183; Thu, 06 Feb 2020 00:17:28 -0800 (PST) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id p3sm3250920wrx.29.2020.02.06.00.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 00:17:27 -0800 (PST) Date: Thu, 6 Feb 2020 09:17:26 +0100 From: Olivier Matz To: Viacheslav Ovsiienko Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com, orika@mellanox.com, shahafs@mellanox.com, stephen@networkplumber.org, thomas@mellanox.net Message-ID: <20200206081726.GM22738@platinum> References: <20191118094938.192850-1-shahafs@mellanox.com> <1579897518-29362-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579897518-29362-1-git-send-email-viacheslavo@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] app/test: add test for mbuf with pinned external buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Fri, Jan 24, 2020 at 08:25:18PM +0000, Viacheslav Ovsiienko wrote: > This patch adds unit test for the mbufs allocated from > the special pool with pinned external data buffers. > > The pinned buffer mbufs are tested in the same way as > regular ones with taking into account some specifics > of cloning/attaching. > > Signed-off-by: Viacheslav Ovsiienko Looks good to me, you can add my ack in the v2, once we understand the issue with verify_mbuf_check_panics(). > @@ -1199,10 +1212,11 @@ > buf = rte_pktmbuf_alloc(pktmbuf_pool); > if (buf == NULL) > return -1; > + /* > printf("Checking good mbuf initially\n"); > if (verify_mbuf_check_panics(buf) != -1) > return -1; > - > + */ > printf("Now checking for error conditions\n"); > > if (verify_mbuf_check_panics(NULL)) { > @@ -2411,6 +2425,120 @@ struct test_case { Note: on my platform, it still works if I remove this comment. Regards, Olivier