From: Mohammed Gamal <mgamal@redhat.com>
To: dev@dpdk.org, sthemmin@microsoft.com
Cc: kys@microsoft.com, haiyangz@microsoft.com,
Mohammed Gamal <mgamal@redhat.com>
Subject: [dpdk-dev] [PATCH] netvsc: update link info when getting device info
Date: Thu, 6 Feb 2020 12:55:41 +0200 [thread overview]
Message-ID: <20200206105541.1186-1-mgamal@redhat.com> (raw)
testpmd 'show summary' command always shows interface status as down
with 0 Mbps speed regardless of the underlying VF's status.
This happens as hn_dev_link_update() is never called, even on the initial
RNDIS_STATUS_MEDIA_CONNECT message as LSC interrupts are not yet enabled
at this point.
Let's call it and update link info when calling hn_dev_info_get().
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
drivers/net/netvsc/hn_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index c79f92437..1120fc688 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -265,6 +265,11 @@ static int hn_dev_info_get(struct rte_eth_dev *dev,
if (rc != 0)
return rc;
+ /* fill in link status and link speed */
+ rc = hn_dev_link_update(dev, 0);
+ if (rc != 0)
+ return rc;
+
/* merges the offload and queues of vf */
return hn_vf_info_get(hv, dev_info);
}
--
2.21.0
next reply other threads:[~2020-02-06 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 10:55 Mohammed Gamal [this message]
2020-02-06 23:45 ` Stephen Hemminger
2020-02-07 0:10 ` [dpdk-dev] [RFT] net/netvsc: initialize link state Stephen Hemminger
2020-02-07 13:22 ` Mohammed Gamal
2020-02-07 16:12 ` Stephen Hemminger
2020-02-07 16:26 ` Mohammed Gamal
2020-02-07 18:08 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-02-10 13:10 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206105541.1186-1-mgamal@redhat.com \
--to=mgamal@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).