From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D06A0542; Fri, 7 Feb 2020 19:24:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 615461BFFB; Fri, 7 Feb 2020 19:24:57 +0100 (CET) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id DC1051BFEB for ; Fri, 7 Feb 2020 19:24:55 +0100 (CET) Received: by mail-pj1-f65.google.com with SMTP id fa20so1248742pjb.1 for ; Fri, 07 Feb 2020 10:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=avdYFgA98lhf/w8kVJv77wWShaZeBZckSeaLd24Dkqk=; b=kfWaa1XhTs7TzV8ocMBaoEVCyOxMYWFbZvr26Ydv75hPuyPp7zPCDhAowXERmAm7g2 0oNZCuon1GoEZW0tYZhOT27KR7e7gWRg/QtC09zln8UW7zjEz06A2lioddOVF9RGzLe8 DfqYIcu+Wqmyv9LQCIRXHVlpSBB8bDobXXsBlR5FW8k5jB7murrmu2cgT7J1H2WxDKzm DzYDZtnD9oFB5D/dNIDKyHiVg3ozXQjKDiN3jl/nflF90sv5HeE/wF0gtyIsdl1akWsT TR7Fu7p6EngIg/Pn+x7eYCq7N5SfA1bw6VPgdWxt3nl7sHo8iNiTWGFbgK2OtXGE28DL dZsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=avdYFgA98lhf/w8kVJv77wWShaZeBZckSeaLd24Dkqk=; b=qzfsJlotVUyb5oO3XArZrSta1mXgUfys4+i+8e+YjD7qcVi+mycVc00U3G0EAoYRGV cXTXoFSKpqoxx9mgJ0ztre/naVAZJfUrVZNNTCDVBANpb8NvjMBQjwcpQop2LYmDhjNv 07ukdZhSCgkiAjRpjVxiz5Gl/fegMqi6wkPDCEyeTrgS+lx5C+0VbthcNlEUSPqYnfx4 p+pirnmX9/YfaIlImy3ZvD7Eodsrv2vH4n6bnbTjNNoGSmB7doLW/J9t7B0eNdLqNrcx Y27S7QW4yR6XBzRcRcx4yCJgzphc0LxA6PKczs9WBOzMN4qAkXVb0GL3VPQnFORyGNYx 0U9w== X-Gm-Message-State: APjAAAXRBgFXiZuvaltaEFUcCAfKLEb7kgd4PyKwDUQHyuGdOSmWVIuf Y5m41BNqRa3zwW0lAtgCTpgr5A== X-Google-Smtp-Source: APXvYqwAhvNsgCrIY+MPjY56HB52vqXKHhx3jQGFefdW69/Oovq1DtPQ6eWAY9pzQnjFGA7Poxr+JQ== X-Received: by 2002:a17:902:a588:: with SMTP id az8mr18979plb.123.1581099894871; Fri, 07 Feb 2020 10:24:54 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z30sm4006892pfq.154.2020.02.07.10.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 10:24:54 -0800 (PST) Date: Fri, 7 Feb 2020 10:24:46 -0800 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20200207102446.35df7b2c@hermes.lan> In-Reply-To: References: <20200104013341.19809-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/14] cleanup resources on shutdown X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 6 Feb 2020 15:06:56 +0100 David Marchand wrote: > On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger > wrote: > > > > Recently started using valgrind with DPDK, and the results > > are not clean. > > > > The DPDK has a function that applications can use to tell it > > to cleanup resources on shutdown (rte_eal_cleanup). But the > > current coverage of that API is spotty. Many internal parts of > > DPDK leave files and allocated memory behind. > > > > This patch set is a start at getting the sub-parts of > > DPDK to cleanup after themselves. These are the easier ones, > > the harder and more critical ones are in the drivers > > and the memory subsystem. > > I am too short on time to check and integrate this big series in rc2, > and from now it would be too risky to take in 20.02. > Can you respin it for 20.05 with FreeBSD fixes too? OK, but if this kind of patch can't be reviewed then the DPDK process is still broken. I don't see how FreeBSD matters here. It can be leaky but that is ok. I split it out to get review, then you complain it is too big :-(