* [dpdk-dev] [PATCH] crypto/ccp: fix queue alignment
@ 2020-02-07 14:06 David Marchand
2020-02-12 13:14 ` Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2020-02-07 14:06 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, stable, Ravi Kumar
Caught by compiling with -fno-common.
A ____cacheline_aligned symbol can be found in the crypto/ccp driver
object files.
Looking at this driver source, the ____cacheline_aligned (kernel?)
alignment macro is undefined.
The compiler treats this as a symbol definition and generates a global
symbol.
Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/crypto/ccp/ccp_dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp_dev.h b/drivers/crypto/ccp/ccp_dev.h
index f4ad9eafd..37e04218c 100644
--- a/drivers/crypto/ccp/ccp_dev.h
+++ b/drivers/crypto/ccp/ccp_dev.h
@@ -220,7 +220,7 @@ struct ccp_queue {
/**< lsb assigned for sha ctx */
uint32_t sb_hmac;
/**< lsb assigned for hmac ctx */
-} ____cacheline_aligned;
+} __rte_cache_aligned;
/**
* A structure describing a CCP device.
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/ccp: fix queue alignment
2020-02-07 14:06 [dpdk-dev] [PATCH] crypto/ccp: fix queue alignment David Marchand
@ 2020-02-12 13:14 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2020-02-12 13:14 UTC (permalink / raw)
To: David Marchand, dev; +Cc: stable, Ravi Kumar
>
> Caught by compiling with -fno-common.
> A ____cacheline_aligned symbol can be found in the crypto/ccp driver
> object files.
>
> Looking at this driver source, the ____cacheline_aligned (kernel?)
> alignment macro is undefined.
> The compiler treats this as a symbol definition and generates a global
> symbol.
>
> Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-12 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 14:06 [dpdk-dev] [PATCH] crypto/ccp: fix queue alignment David Marchand
2020-02-12 13:14 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).