From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 721BEA0531; Mon, 10 Feb 2020 07:59:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6435F1BE94; Mon, 10 Feb 2020 07:59:01 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 708BB2BFA for ; Mon, 10 Feb 2020 07:58:59 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 22:58:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="433231211" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga006.fm.intel.com with ESMTP; 09 Feb 2020 22:58:57 -0800 Date: Mon, 10 Feb 2020 14:57:44 +0800 From: Ye Xiaolong To: Guinan Sun Cc: dev@dpdk.org, Wenzhuo Lu , Qiming Yang Message-ID: <20200210065744.GC80720@intel.com> References: <20200210041525.50893-1-guinanx.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200210041525.50893-1-guinanx.sun@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/10, Guinan Sun wrote: >This patch fixes (Logically dead code) coverity issue. > >Coverity issue: 353613 >Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove") > >Signed-off-by: Guinan Sun >--- > drivers/net/ixgbe/ixgbe_pf.c | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c >index 493f0f2b9..afae21f81 100644 >--- a/drivers/net/ixgbe/ixgbe_pf.c >+++ b/drivers/net/ixgbe/ixgbe_pf.c >@@ -772,9 +772,6 @@ ixgbe_set_vf_macvlan_msg(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) > IXGBE_VT_MSGINFO_SHIFT; > > if (index) { >- if (new_mac == NULL) >- return -1; >- > if (!rte_is_valid_assigned_ether_addr( > (struct rte_ether_addr *)new_mac)) { > PMD_DRV_LOG(ERR, "set invalid mac vf:%d\n", vf); >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.