From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22B60A0531; Wed, 12 Feb 2020 11:35:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32A05262E; Wed, 12 Feb 2020 11:35:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 22A572629 for ; Wed, 12 Feb 2020 11:35:47 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 02:35:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="432279569" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by fmsmga005.fm.intel.com with ESMTP; 12 Feb 2020 02:35:45 -0800 Date: Wed, 12 Feb 2020 18:35:36 +0800 From: Tiwei Bie To: Ivan Dyukov Cc: dev@dpdk.org, maxime.coquelin@redhat.com, amorenoz@redhat.com Message-ID: <20200212103528.GA786542@___> References: <20200207112526.11455-1-i.dyukov@samsung.com> <20200207112526.11455-2-i.dyukov@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200207112526.11455-2-i.dyukov@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: > Some applications like pktgen use link_speed to calculate > transmit rate. It limits outcome traffic to hardcoded 10G. > > This patch adds link_speed devarg which allows to configure > link_speed of virtio device. > > Signed-off-by: Ivan Dyukov > --- > doc/guides/nics/virtio.rst | 7 ++ > drivers/net/virtio/virtio_ethdev.c | 101 ++++++++++++++++++++++++----- > drivers/net/virtio/virtio_pci.h | 1 + > 3 files changed, 92 insertions(+), 17 deletions(-) Maybe I missed something.. Why not enable the VIRTIO_NET_F_SPEED_DUPLEX support directly? When that feature is supported and negotiated, we will ignore this devarg? If we want this devarg, it looks better to support it in virtio-user as well (most code is shared between virtio-PMD and virtio-user). Thanks! Tiwei