[dpdk-dev] Dropping python 2 support

[dpdk-dev] Dropping python 2 support

[Robin Jarry]

Hi all,

As you may have noticed, Python 2 is officially end-of-life since
January 1st 2020.

https://www.python.org/doc/sunset-python-2/

Some projects have already decided to drop python 2 support:

https://github.com/openvswitch/ovs/commit/1ca0323e7c29
https://wiki.debian.org/Python/2Removal
https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html

I figure this may be the opportunity to do the same in DPDK. Does anyone
have arguments against this? If not, I am willing to work on the matter.

-- 
Robin

Re: [dpdk-dev] Dropping python 2 support

[Bruce Richardson]

On Wed, Feb 12, 2020 at 02:41:56PM +0100, Robin Jarry wrote:
> Hi all,
> 
> As you may have noticed, Python 2 is officially end-of-life since
> January 1st 2020.
> 
> https://www.python.org/doc/sunset-python-2/
> 
> Some projects have already decided to drop python 2 support:
> 
> https://github.com/openvswitch/ovs/commit/1ca0323e7c29
> https://wiki.debian.org/Python/2Removal
> https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
> 
> I figure this may be the opportunity to do the same in DPDK. Does anyone
> have arguments against this? If not, I am willing to work on the matter.
> 
I'm in favour of dropping the support in general, however, do we still not
need to support some distro's e.g. Redhat/CentOS 7, which do not have
python3?

/Bruce

Re: [dpdk-dev] Dropping python 2 support

[Robin Jarry]

2020-02-12, Bruce Richardson:
> I'm in favour of dropping the support in general, however, do we still not
> need to support some distro's e.g. Redhat/CentOS 7, which do not have
> python3?

Since the 7.7 release, python3 is now officially available in the
official repos:

https://access.redhat.com/solutions/2353081
> August 8 2019 at 5:40 PM
>
> As of RHEL 7.7, python3 is included into base RHEL 7 channels without
> the need for software collections. Note: this does not replace the
> need for having python2 as the system default python for OS utilities
> on RHEL 7.

Moreover, I figure that Redhat/CentOS 7 will be using an LTS version,
not the latest master snapshot.

-- 
Robin

Re: [dpdk-dev] Dropping python 2 support

[Kevin Traynor]

On 13/02/2020 08:25, Robin Jarry wrote:
> 2020-02-12, Bruce Richardson:
>> I'm in favour of dropping the support in general, however, do we still not
>> need to support some distro's e.g. Redhat/CentOS 7, which do not have
>> python3?
> 
> Since the 7.7 release, python3 is now officially available in the
> official repos:
> 
> https://access.redhat.com/solutions/2353081

Yes, that's right.

https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7.1908?action=show&redirect=Manuals%2FReleaseNotes%2FCentOS7#Major_Changes

>> August 8 2019 at 5:40 PM
>>
>> As of RHEL 7.7, python3 is included into base RHEL 7 channels without
>> the need for software collections. Note: this does not replace the
>> need for having python2 as the system default python for OS utilities
>> on RHEL 7.
> 
> Moreover, I figure that Redhat/CentOS 7 will be using an LTS version,
> not the latest master snapshot.
> 

That is true for the distribution versions, but there may be developers
doing some compiling themselves using latest.

I think it would be ok to start the process of removing python2 from
DPDK...but...there probably needs to be some deprecation notice and time
to allow people upgrade or raise any concerns.

At least, I see some test reports for LTS coming back as run on older
RHEL/CentOS 7 versions (probably master too), so some people will need
to schedule upgrades.

Re: [dpdk-dev] Dropping python 2 support

[Robin Jarry]

2020-02-13, Kevin Traynor:
> That is true for the distribution versions, but there may be developers
> doing some compiling themselves using latest.
> 
> I think it would be ok to start the process of removing python2 from
> DPDK...but...there probably needs to be some deprecation notice and time
> to allow people upgrade or raise any concerns.

We could insert DeprecationWarnings in the python scripts when executed
with python2 but I fear this could break things that rely on these
scripts output.

  https://docs.python.org/2/library/warnings.html#warnings.warn

I'm not sure how to prevent this kind of issues though.

About official deprecation notices, I figure the decision must be made
by maintainers and/or the technical board.

-- 
Robin

Re: [dpdk-dev] Dropping python 2 support

[Bruce Richardson]

On Thu, Feb 13, 2020 at 11:28:53AM +0100, Robin Jarry wrote:
> 2020-02-13, Kevin Traynor:
> > That is true for the distribution versions, but there may be developers
> > doing some compiling themselves using latest.
> > 
> > I think it would be ok to start the process of removing python2 from
> > DPDK...but...there probably needs to be some deprecation notice and time
> > to allow people upgrade or raise any concerns.
> 
> We could insert DeprecationWarnings in the python scripts when executed
> with python2 but I fear this could break things that rely on these
> scripts output.
> 
>   https://docs.python.org/2/library/warnings.html#warnings.warn
> 
> I'm not sure how to prevent this kind of issues though.
> 
> About official deprecation notices, I figure the decision must be made
> by maintainers and/or the technical board.
> 
Yes. I'd suggest for 20.05 perhaps putting a deprecation notice in the docs
and then later (20.08) putting warnings in the code. Perhaps full removal of
support should be done for 20.11, or do we need one more LTS release with
the support still present?

/Bruce

Re: [dpdk-dev] Dropping python 2 support

[Robin Jarry]

2020-02-13, Bruce Richardson:
> Yes. I'd suggest for 20.05 perhaps putting a deprecation notice in the docs
> and then later (20.08) putting warnings in the code. Perhaps full removal of
> support should be done for 20.11, or do we need one more LTS release with
> the support still present?

I'll prepare a documentation patch then.

-- 
Robin

[dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[Robin Jarry]

Now that Python 2 is officially not maintained anymore, prepare the
removal of support in DPDK.

Add a deprecation notice indicating the removal schedule.

Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Kevin Traynor <ktraynor@redhat.com>
Cc: Timothy Redaelli <tredaelli@redhat.com>

Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index dfcca87ab95a..8f476bc5a9e9 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -91,3 +91,9 @@ Deprecation Notices
   to set new power environment if power environment was already initialized.
   In this case the function will return -1 unless the environment is unset first
   (using ``rte_power_unset_env``). Other function usage scenarios will not change.
+
+* python: Since the beginning of 2020, Python 2 has officially reached
+  end-of-support: https://www.python.org/doc/sunset-python-2/.
+  Python 2 support will be completely removed in 20.11.
+  In 20.08, explicit deprecation warnings will be displayed when running
+  scripts with Python 2.
-- 
2.24.1

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[Bruce Richardson]

On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote:
> Now that Python 2 is officially not maintained anymore, prepare the
> removal of support in DPDK.
> 
> Add a deprecation notice indicating the removal schedule.
> 
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Timothy Redaelli <tredaelli@redhat.com>
> 
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index dfcca87ab95a..8f476bc5a9e9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,3 +91,9 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* python: Since the beginning of 2020, Python 2 has officially reached
> +  end-of-support: https://www.python.org/doc/sunset-python-2/.
> +  Python 2 support will be completely removed in 20.11.
> +  In 20.08, explicit deprecation warnings will be displayed when running
> +  scripts with Python 2.
> -- 
> 2.24.1
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[Neil Horman]

On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote:
> Now that Python 2 is officially not maintained anymore, prepare the
> removal of support in DPDK.
> 
> Add a deprecation notice indicating the removal schedule.
> 
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Timothy Redaelli <tredaelli@redhat.com>
> 
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index dfcca87ab95a..8f476bc5a9e9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,3 +91,9 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* python: Since the beginning of 2020, Python 2 has officially reached
> +  end-of-support: https://www.python.org/doc/sunset-python-2/.
> +  Python 2 support will be completely removed in 20.11.
> +  In 20.08, explicit deprecation warnings will be displayed when running
> +  scripts with Python 2.
> -- 
> 2.24.1
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[Thomas Monjalon]

17/02/2020 11:42, Bruce Richardson:
> On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote:
> > Now that Python 2 is officially not maintained anymore, prepare the
> > removal of support in DPDK.
> > 
> > Add a deprecation notice indicating the removal schedule.
> > 
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Cc: Kevin Traynor <ktraynor@redhat.com>
> > Cc: Timothy Redaelli <tredaelli@redhat.com>
> > 
> > Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> > ---
> > +* python: Since the beginning of 2020, Python 2 has officially reached
> > +  end-of-support: https://www.python.org/doc/sunset-python-2/.
> > +  Python 2 support will be completely removed in 20.11.
> > +  In 20.08, explicit deprecation warnings will be displayed when running
> > +  scripts with Python 2.

> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[Kevin Traynor]

On 17/02/2020 09:26, Robin Jarry wrote:
> Now that Python 2 is officially not maintained anymore, prepare the
> removal of support in DPDK.
> 
> Add a deprecation notice indicating the removal schedule.
> 
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Timothy Redaelli <tredaelli@redhat.com>
> 
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index dfcca87ab95a..8f476bc5a9e9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,3 +91,9 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* python: Since the beginning of 2020, Python 2 has officially reached
> +  end-of-support: https://www.python.org/doc/sunset-python-2/.
> +  Python 2 support will be completely removed in 20.11.
> +  In 20.08, explicit deprecation warnings will be displayed when running
> +  scripts with Python 2.
> 

Acked-by: Kevin Traynor <ktraynor@redhat.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[David Marchand]

On Mon, Feb 17, 2020 at 10:27 AM Robin Jarry <robin.jarry@6wind.com> wrote:
>
> Now that Python 2 is officially not maintained anymore, prepare the
> removal of support in DPDK.
>
> Add a deprecation notice indicating the removal schedule.
>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Timothy Redaelli <tredaelli@redhat.com>
>
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index dfcca87ab95a..8f476bc5a9e9 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,3 +91,9 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* python: Since the beginning of 2020, Python 2 has officially reached
> +  end-of-support: https://www.python.org/doc/sunset-python-2/.
> +  Python 2 support will be completely removed in 20.11.
> +  In 20.08, explicit deprecation warnings will be displayed when running
> +  scripts with Python 2.
> --
> 2.24.1
>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

[David Marchand]

On Mon, Feb 17, 2020 at 10:27 AM Robin Jarry <robin.jarry@6wind.com> wrote:
>
> Now that Python 2 is officially not maintained anymore, prepare the
> removal of support in DPDK.
>
> Add a deprecation notice indicating the removal schedule.
>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Timothy Redaelli <tredaelli@redhat.com>
>
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: David Marchand <david.marchand@redhat.com>


Applied, thanks.

-- 
David Marchand