From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E117A0542; Thu, 13 Feb 2020 13:10:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A17901BFA3; Thu, 13 Feb 2020 13:10:05 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 958461BFA2; Thu, 13 Feb 2020 13:10:04 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 04:10:03 -0800 X-IronPort-AV: E=Sophos;i="5.70,436,1574150400"; d="scan'208";a="227215281" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Feb 2020 04:10:01 -0800 Date: Thu, 13 Feb 2020 12:09:58 +0000 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200213120958.GA845@bricha3-MOBL.ger.corp.intel.com> References: <20200204160006.64720-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200204160006.64720-1-ciara.power@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 04, 2020 at 04:00:06PM +0000, Ciara Power wrote: > The nb_dq return value from the ioat dequeue is negative in failure > cases, however the variable was an unsigned int, causing the condition > where nb_dq <= 0 to never be true. This is now cast to a signed int, > which will successfully reflect the -1 value to be used in this > conditional check. > > Coverity issue: 350342 > Coverity issue: 350349 > Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power Acked-by: Bruce Richardson