DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH  v1 0/2] add travis ci support for ppc64le
@ 2020-02-13 20:24 David Wilder
  2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le David Wilder
  2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 2/2] ci: add travis ci support for native ppc64le David Wilder
  0 siblings, 2 replies; 8+ messages in thread
From: David Wilder @ 2020-02-13 20:24 UTC (permalink / raw)
  To: aconole, maicolgabriel, thomas, ferruh.yigit, arybchenko
  Cc: dev, ruifeng.wang, david.marchand, drc, wilder

This patch series adds Travis gcc compilation jobs for ppc64le.
Limitations for ppc64le are similar to arm64 (see commit
31bb45bcfd).

1. Only gcc builds are supported on ppc64le.

2. A container is used, therefor Huge pages are not available.
   Unit tests are not run, a single test (test-null) using the
   no-huge option is run.

The first patch in the series adjusts parameters for devtools/test-null.sh
as required for ppc64le.

A Travis build with theses two patches can be found here:
https://travis-ci.org/djlwilder/dpdk/builds/650091701

David Wilder (2):
  devtools: allow test-null.sh to run on ppc64le
  ci: add travis ci support for native ppc64le

 .travis.yml           | 29 +++++++++++++++++++++++++++++
 devtools/test-null.sh |  2 +-
 2 files changed, 30 insertions(+), 1 deletion(-)

-- 
2.25.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 20:24 [dpdk-dev] [PATCH v1 0/2] add travis ci support for ppc64le David Wilder
@ 2020-02-13 20:24 ` David Wilder
  2020-02-13 20:32   ` Thomas Monjalon
  2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 2/2] ci: add travis ci support for native ppc64le David Wilder
  1 sibling, 1 reply; 8+ messages in thread
From: David Wilder @ 2020-02-13 20:24 UTC (permalink / raw)
  To: aconole, maicolgabriel, thomas, ferruh.yigit, arybchenko
  Cc: dev, ruifeng.wang, david.marchand, drc, wilder

- Memory requirements are larger for ppc64le
  due to a higher RTE_MAX_LCORE value.

- The --no-huge option requires iova-mode=VA.
  On ppc64le iova-mode defaults to PA therefor
  VA mode must be explicitly set.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
---
 devtools/test-null.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/test-null.sh b/devtools/test-null.sh
index 548de8113..85952d1dc 100755
--- a/devtools/test-null.sh
+++ b/devtools/test-null.sh
@@ -27,6 +27,6 @@ else
 fi
 
 (sleep 1 && echo stop) |
-$testpmd -c $coremask --no-huge -m 20 \
+$testpmd -c $coremask --no-huge -m 30 --iova-mode=va \
 	$libs -w 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \
 	--no-mlockall --total-num-mbufs=2048 $testpmd_options -ia
-- 
2.25.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v1 2/2] ci: add travis ci support for native ppc64le
  2020-02-13 20:24 [dpdk-dev] [PATCH v1 0/2] add travis ci support for ppc64le David Wilder
  2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le David Wilder
@ 2020-02-13 20:24 ` David Wilder
  1 sibling, 0 replies; 8+ messages in thread
From: David Wilder @ 2020-02-13 20:24 UTC (permalink / raw)
  To: aconole, maicolgabriel, thomas, ferruh.yigit, arybchenko
  Cc: dev, ruifeng.wang, david.marchand, drc, wilder

This change follows the example of aarch64 Travis support
by adding support for ppc64le gcc builds.  Limitations for
ppc64le are the same as aarch64 as described in commit
31bb45bcfd.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
---
 .travis.yml | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 22539d823..1e95cbe57 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -167,5 +167,34 @@ matrix:
       apt:
         packages:
           - *extra_packages
+  - env: DEF_LIB="static"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+          - *doc_packages
+  - env: DEF_LIB="shared" EXTRA_PACKAGES=1 ABI_CHECKS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *extra_packages
 
 script: ./.ci/${TRAVIS_OS_NAME}-build.sh
-- 
2.25.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le David Wilder
@ 2020-02-13 20:32   ` Thomas Monjalon
  2020-02-13 20:58     ` dwilder
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2020-02-13 20:32 UTC (permalink / raw)
  To: david.marchand, anatoly.burakov
  Cc: aconole, maicolgabriel, ferruh.yigit, arybchenko, David Wilder,
	dev, ruifeng.wang, drc, wilder

13/02/2020 21:24, David Wilder:
> - The --no-huge option requires iova-mode=VA.
>   On ppc64le iova-mode defaults to PA therefor
>   VA mode must be explicitly set.

Should we make VA mode automatic when using --no-huge?
Should we log an error message when using --no-huge with PA mode?




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 20:32   ` Thomas Monjalon
@ 2020-02-13 20:58     ` dwilder
  2020-02-13 22:17       ` Thomas Monjalon
  0 siblings, 1 reply; 8+ messages in thread
From: dwilder @ 2020-02-13 20:58 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: david.marchand, anatoly.burakov, aconole, maicolgabriel,
	ferruh.yigit, arybchenko, dev, ruifeng.wang, drc, wilder

On 2020-02-13 12:32, Thomas Monjalon wrote:
> 13/02/2020 21:24, David Wilder:
>> - The --no-huge option requires iova-mode=VA.
>>   On ppc64le iova-mode defaults to PA therefor
>>   VA mode must be explicitly set.
> 
> Should we make VA mode automatic when using --no-huge?
> Should we log an error message when using --no-huge with PA mode?

Logging a messages sounds like a good idea.  Ignoring the users request 
of iova-mode=PA (in the case of x86) and just switching modes would be 
bad.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 20:58     ` dwilder
@ 2020-02-13 22:17       ` Thomas Monjalon
  2020-02-13 23:23         ` dwilder
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2020-02-13 22:17 UTC (permalink / raw)
  To: dwilder
  Cc: david.marchand, anatoly.burakov, aconole, maicolgabriel,
	ferruh.yigit, arybchenko, dev, ruifeng.wang, drc, wilder

13/02/2020 21:58, dwilder:
> On 2020-02-13 12:32, Thomas Monjalon wrote:
> > 13/02/2020 21:24, David Wilder:
> >> - The --no-huge option requires iova-mode=VA.
> >>   On ppc64le iova-mode defaults to PA therefor
> >>   VA mode must be explicitly set.
> > 
> > Should we make VA mode automatic when using --no-huge?
> > Should we log an error message when using --no-huge with PA mode?
> 
> Logging a messages sounds like a good idea.  Ignoring the users request 
> of iova-mode=PA (in the case of x86) and just switching modes would be 
> bad.

Yes, I mean for ppc64, if --no-huge is specified,
would you like to change the default to VA mode?



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 22:17       ` Thomas Monjalon
@ 2020-02-13 23:23         ` dwilder
  2020-02-14 13:22           ` David Marchand
  0 siblings, 1 reply; 8+ messages in thread
From: dwilder @ 2020-02-13 23:23 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: david.marchand, anatoly.burakov, aconole, maicolgabriel,
	ferruh.yigit, arybchenko, dev, ruifeng.wang, drc, wilder

On 2020-02-13 14:17, Thomas Monjalon wrote:
> 13/02/2020 21:58, dwilder:
>> On 2020-02-13 12:32, Thomas Monjalon wrote:
>> > 13/02/2020 21:24, David Wilder:
>> >> - The --no-huge option requires iova-mode=VA.
>> >>   On ppc64le iova-mode defaults to PA therefor
>> >>   VA mode must be explicitly set.
>> >
>> > Should we make VA mode automatic when using --no-huge?
>> > Should we log an error message when using --no-huge with PA mode?
>> 
>> Logging a messages sounds like a good idea.  Ignoring the users 
>> request
>> of iova-mode=PA (in the case of x86) and just switching modes would be
>> bad.
> 
> Yes, I mean for ppc64, if --no-huge is specified,
> would you like to change the default to VA mode?

OK, that would be better.
I will switch to VA when --no-huge is set (ppc64 only).
Add log messages if PA is selected with --no-huge (all arches).

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le
  2020-02-13 23:23         ` dwilder
@ 2020-02-14 13:22           ` David Marchand
  0 siblings, 0 replies; 8+ messages in thread
From: David Marchand @ 2020-02-14 13:22 UTC (permalink / raw)
  To: dwilder
  Cc: Thomas Monjalon, Burakov, Anatoly, Aaron Conole, Michael Santana,
	Yigit, Ferruh, Andrew Rybchenko, dev,
	Ruifeng Wang (Arm Technology China),
	David Christensen, David Wilder

On Fri, Feb 14, 2020 at 12:22 AM dwilder <dwilder@us.ibm.com> wrote:
>
> On 2020-02-13 14:17, Thomas Monjalon wrote:
> > 13/02/2020 21:58, dwilder:
> >> On 2020-02-13 12:32, Thomas Monjalon wrote:
> >> > 13/02/2020 21:24, David Wilder:
> >> >> - The --no-huge option requires iova-mode=VA.
> >> >>   On ppc64le iova-mode defaults to PA therefor
> >> >>   VA mode must be explicitly set.
> >> >
> >> > Should we make VA mode automatic when using --no-huge?
> >> > Should we log an error message when using --no-huge with PA mode?
> >>
> >> Logging a messages sounds like a good idea.  Ignoring the users
> >> request
> >> of iova-mode=PA (in the case of x86) and just switching modes would be
> >> bad.
> >
> > Yes, I mean for ppc64, if --no-huge is specified,
> > would you like to change the default to VA mode?
>
> OK, that would be better.
> I will switch to VA when --no-huge is set (ppc64 only).

With no-huge, we can't ensure the physical addresses won't change
(might be different if we locked the pages in memory... but not
possible and/or not handled in eal afaics).
This limitation is generic, not arch specific.


> Add log messages if PA is selected with --no-huge (all arches).

-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 20:24 [dpdk-dev] [PATCH v1 0/2] add travis ci support for ppc64le David Wilder
2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le David Wilder
2020-02-13 20:32   ` Thomas Monjalon
2020-02-13 20:58     ` dwilder
2020-02-13 22:17       ` Thomas Monjalon
2020-02-13 23:23         ` dwilder
2020-02-14 13:22           ` David Marchand
2020-02-13 20:24 ` [dpdk-dev] [PATCH v1 2/2] ci: add travis ci support for native ppc64le David Wilder

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox