From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Sunil Pai G <sunil.pai.g@intel.com>
Cc: qiming.yang@intel.com, dev@dpdk.org, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value
Date: Fri, 14 Feb 2020 17:46:34 +0800 [thread overview]
Message-ID: <20200214094634.GB16933@intel.com> (raw)
In-Reply-To: <20200212053710.16424-1-sunil.pai.g@intel.com>
On 02/12, Sunil Pai G wrote:
>This checks the return value of the function ice_xmit_cleanup
>
>Coverity issue: 353623
>Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>Cc: wenzhuo.lu@intel.com
Cc: stable@dpdk.org
>
>Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com>
>---
> drivers/net/ice/ice_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
>index ce5b8e6ca..60c411bfa 100644
>--- a/drivers/net/ice/ice_rxtx.c
>+++ b/drivers/net/ice/ice_rxtx.c
>@@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
>
> /* Check if the descriptor ring needs to be cleaned. */
> if (txq->nb_tx_free < txq->tx_free_thresh)
>- ice_xmit_cleanup(txq);
>+ (void)ice_xmit_cleanup(txq);
>
> for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
> tx_pkt = *tx_pkts++;
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-02-14 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 5:37 Sunil Pai G
2020-02-14 9:46 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214094634.GB16933@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=sunil.pai.g@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).