DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value
@ 2020-02-12  5:37 Sunil Pai G
  2020-02-14  9:46 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: Sunil Pai G @ 2020-02-12  5:37 UTC (permalink / raw)
  To: qiming.yang; +Cc: dev, wenzhuo.lu

This checks the return value of the function ice_xmit_cleanup

Coverity issue: 353623
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: wenzhuo.lu@intel.com

Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ce5b8e6ca..60c411bfa 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 
 	/* Check if the descriptor ring needs to be cleaned. */
 	if (txq->nb_tx_free < txq->tx_free_thresh)
-		ice_xmit_cleanup(txq);
+		(void)ice_xmit_cleanup(txq);
 
 	for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
 		tx_pkt = *tx_pkts++;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value
  2020-02-12  5:37 [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value Sunil Pai G
@ 2020-02-14  9:46 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-02-14  9:46 UTC (permalink / raw)
  To: Sunil Pai G; +Cc: qiming.yang, dev, wenzhuo.lu

On 02/12, Sunil Pai G wrote:
>This checks the return value of the function ice_xmit_cleanup
>
>Coverity issue: 353623
>Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>Cc: wenzhuo.lu@intel.com

Cc: stable@dpdk.org

>
>Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com>
>---
> drivers/net/ice/ice_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
>index ce5b8e6ca..60c411bfa 100644
>--- a/drivers/net/ice/ice_rxtx.c
>+++ b/drivers/net/ice/ice_rxtx.c
>@@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
> 
> 	/* Check if the descriptor ring needs to be cleaned. */
> 	if (txq->nb_tx_free < txq->tx_free_thresh)
>-		ice_xmit_cleanup(txq);
>+		(void)ice_xmit_cleanup(txq);
> 
> 	for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
> 		tx_pkt = *tx_pkts++;
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12  5:37 [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value Sunil Pai G
2020-02-14  9:46 ` Ye Xiaolong

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox