From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96574A0546; Fri, 14 Feb 2020 10:48:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64BAD1F28; Fri, 14 Feb 2020 10:48:04 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 66D911DB9 for ; Fri, 14 Feb 2020 10:48:02 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 01:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="252585080" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga002.jf.intel.com with ESMTP; 14 Feb 2020 01:47:59 -0800 Date: Fri, 14 Feb 2020 17:46:34 +0800 From: Ye Xiaolong To: Sunil Pai G Cc: qiming.yang@intel.com, dev@dpdk.org, wenzhuo.lu@intel.com Message-ID: <20200214094634.GB16933@intel.com> References: <20200212053710.16424-1-sunil.pai.g@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212053710.16424-1-sunil.pai.g@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/12, Sunil Pai G wrote: >This checks the return value of the function ice_xmit_cleanup > >Coverity issue: 353623 >Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") >Cc: wenzhuo.lu@intel.com Cc: stable@dpdk.org > >Signed-off-by: Sunil Pai G >--- > drivers/net/ice/ice_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c >index ce5b8e6ca..60c411bfa 100644 >--- a/drivers/net/ice/ice_rxtx.c >+++ b/drivers/net/ice/ice_rxtx.c >@@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > /* Check if the descriptor ring needs to be cleaned. */ > if (txq->nb_tx_free < txq->tx_free_thresh) >- ice_xmit_cleanup(txq); >+ (void)ice_xmit_cleanup(txq); > > for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { > tx_pkt = *tx_pkts++; >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.