From: Ciara Power <ciara.power@intel.com> To: olivier.matz@6wind.com, arybchenko@solarflare.com Cc: dev@dpdk.org, Ciara Power <ciara.power@intel.com>, bruce.richardson@intel.com, stable@dpdk.org Subject: [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation Date: Fri, 14 Feb 2020 16:17:25 +0000 Message-ID: <20200214161725.36104-1-ciara.power@intel.com> (raw) In-Reply-To: <20191202091517.17461-1-ciara.power@intel.com> An equality expression already returns either 0 or 1. There is no need to use double negation for these cases. Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") Cc: olivier.matz@6wind.com Cc: bruce.richardson@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Olivier Matz <olivier.matz@6wind.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> --- V2: - Rebased onto master - Changed commit subject and description --- lib/librte_mbuf/rte_mbuf.h | 2 +- lib/librte_mempool/rte_mempool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 219b110b7..6d080527f 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1535,7 +1535,7 @@ static inline int rte_pktmbuf_trim(struct rte_mbuf *m, uint16_t len) static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m) { __rte_mbuf_sanity_check(m, 1); - return !!(m->nb_segs == 1); + return m->nb_segs == 1; } /** diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index f81152af9..e588c5d9b 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/lib/librte_mempool/rte_mempool.h @@ -1653,7 +1653,7 @@ rte_mempool_in_use_count(const struct rte_mempool *mp); static inline int rte_mempool_full(const struct rte_mempool *mp) { - return !!(rte_mempool_avail_count(mp) == mp->size); + return rte_mempool_avail_count(mp) == mp->size; } /** @@ -1672,7 +1672,7 @@ rte_mempool_full(const struct rte_mempool *mp) static inline int rte_mempool_empty(const struct rte_mempool *mp) { - return !!(rte_mempool_avail_count(mp) == 0); + return rte_mempool_avail_count(mp) == 0; } /** -- 2.17.1
next prev parent reply other threads:[~2020-02-14 16:28 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-02 9:15 [dpdk-dev] [PATCH] lib: fix unnecessary boolean casts Ciara Power 2019-12-02 11:58 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2019-12-26 16:21 ` [dpdk-dev] " Olivier Matz 2020-02-14 16:17 ` Ciara Power [this message] 2020-02-14 16:39 ` [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200214161725.36104-1-ciara.power@intel.com \ --to=ciara.power@intel.com \ --cc=arybchenko@solarflare.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=olivier.matz@6wind.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git