DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lance Richardson <lance.richardson@broadcom.com>
To: thomas@monjalon.net
Cc: dev@dpdk.org, Lance Richardson <lance.richardson@broadcom.com>
Subject: [dpdk-dev] [PATCH v2] devtools: check c99 comment use in checkpatches.sh
Date: Sat, 15 Feb 2020 12:09:50 -0500	[thread overview]
Message-ID: <20200215170950.11628-1-lance.richardson@broadcom.com> (raw)
In-Reply-To: <71ad489e-8030-fb06-b405-f29f6c3bc8ea@intel.com>

C99-style comments are not permitted according to DPDK coding
style guidelines, enable checking for these by checkpatch.pl.

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
v2:
* Fixed a typo in commit message.

 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index b16bace92..c996a8780 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,C99_COMMENT_TOLERANCE"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {
-- 
2.17.1


  parent reply	other threads:[~2020-02-15 17:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 16:05 [dpdk-dev] coding style question - c99 comments Lance Richardson
2020-01-23 16:15 ` Stephen Hemminger
2020-01-23 16:43   ` Lance Richardson
2020-01-24 17:07     ` Ferruh Yigit
2020-01-24 21:37       ` Lance Richardson
2020-02-15 17:09       ` Lance Richardson [this message]
2020-02-22 19:52         ` [dpdk-dev] [PATCH v2] devtools: check c99 comment use in checkpatches.sh Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200215170950.11628-1-lance.richardson@broadcom.com \
    --to=lance.richardson@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).