From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EC09A0553; Mon, 17 Feb 2020 16:30:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 012641DAA1; Mon, 17 Feb 2020 16:30:50 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B0CE21D9C3; Mon, 17 Feb 2020 16:30:49 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01HFPId3022929; Mon, 17 Feb 2020 07:30:48 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=ZADfAya2kla3PZII+tV+W/i5Bs81Xev0Y90n9PmRfHM=; b=tKAwyoqW0HXNO3iY210D48AjXT7TWYfyEkQh5Uk8bGevhlljy+Zh+S6tP9LX2Ro4cYqJ xf7mTAGXzIv2rFyMUc40tYUmDljvokoPQW+AeifRLz7R1TS9dxZEapBuHjrlVXU/qCMs UKHDJF4GR9ATqUTDlGwYM+PKMkFn19AZIr6VfLGBx8gikeaXY5IsE/EHAUcRCxGK9Y9r aIh31EAGG3LnGOQDwMtHZZH3GW1k+rHG4QD5GOAk0gUb5H4nAIoOagSIOP7VT1CagJ9f i6XBufF4uGq1PP4Ea8uTglv8zPhzLTjblV2alICW3q++NyEAYqjMqeMZBAo+cV49+yOd GA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2y6h1syfxx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Feb 2020 07:30:48 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 17 Feb 2020 07:30:46 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 17 Feb 2020 07:30:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFcSvj1l/c/HJFpWp0Vo3CFGuWF1H11fkbCTDXy02iHdOZE2XWAH4y9bebJrVXwhWNj9BmsxpH51WEqP2iMj7scgdS5jtZfeVlbh4N5TKA2cBzxfD05zlmH646UbOAMgRCVSw0URi18YMUqbZuI3ZvHn1YhKDArkTllbBh18Fh/X7HEkhNnsPrBEY6vwa1IfQuQbNN5LSuAJO5X4bSMsIe7vqzZx3kujy5WODg0FNzKecJDtBXzUUuX4DyEuRMxoZlP3YnJ4DDF3VtEQ5WELOB0a7WxIH9u+gMWL0uY8jjkWoxd4TIZG48RlzUurhDBctwBVRxUES+eQmeZYuJcE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZADfAya2kla3PZII+tV+W/i5Bs81Xev0Y90n9PmRfHM=; b=bFztRwrYVltNGhtz/t7MpyOQJSYhOyhxlohT1TpDTglcPokAM1dJ1xZd9BDBMTEDp4Me52Dx5L1LKE5sZSS9kiDSpMHANRqTCojmWUkgcTKdcNTUPwxmMKqTS2MtRGjupuUpWIb5+eCX0z+Qg/SQ1W8hGJWXs5ROGkSAodFX4IByVG6Q8ScTFanNjn8Nur/2k7zeY51/HulQOti4878rKpXz365NMMYCOlWSo/ypdld7bw3qgnJY+O3fRMA7XeF8r4m/li0wfjRdFzVwo6hF8BuKQXy25uTwvF4CQ7oPgo9tp83zkdJ1t35NI60bY8qiCpmEJkUzjjdjmsT6b0uuoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZADfAya2kla3PZII+tV+W/i5Bs81Xev0Y90n9PmRfHM=; b=D6j4nwsP0ph40mQ2J96D+WihYWM0wWI8GeRinAAJAC2TpND+rXIahVQJFemmWRV5ryikOO69a1bpVmiOQejfZ8Okka54WmMXN5/23oXzVvAOIxZ1VKi8b2gTssyNX7SZU0jIPzq3e1z/r/aJC6iJD6XEMlB3tnlRmjkEUZDrZ6I= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.20.19) by MN2PR18MB3264.namprd18.prod.outlook.com (10.255.238.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.29; Mon, 17 Feb 2020 15:30:45 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::6de0:6ead:9fc:5beb]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::6de0:6ead:9fc:5beb%3]) with mapi id 15.20.2729.032; Mon, 17 Feb 2020 15:30:44 +0000 Date: Mon, 17 Feb 2020 21:00:28 +0530 From: Harman Kalra To: Ferruh Yigit CC: Jerin Jacob , Vamsi Attunuru , , Message-ID: <20200217153027.GA110928@outlook.office365.com> References: <1581755704-15546-1-git-send-email-hkalra@marvell.com> <194bbbb5-7af3-2bb8-ef0b-e2a571a58efe@intel.com> <20200217143437.GA23753@outlook.office365.com> <842f21a6-8043-0608-0428-98ca07930cbf@intel.com> <20200217150648.GB23753@outlook.office365.com> <7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-ClientProxiedBy: PN1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::18) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) MIME-Version: 1.0 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.24 via Frontend Transport; Mon, 17 Feb 2020 15:30:43 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d4487b7-da4a-4c28-bb6e-08d7b3be5aea X-MS-TrafficTypeDiagnostic: MN2PR18MB3264: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0316567485 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(396003)(39860400002)(376002)(136003)(199004)(189003)(7696005)(86362001)(52116002)(966005)(478600001)(54906003)(316002)(1076003)(956004)(55236004)(6916009)(53546011)(6506007)(5660300002)(16526019)(186003)(66946007)(81156014)(81166006)(66556008)(8936002)(66476007)(9686003)(55016002)(8676002)(33656002)(26005)(2906002)(4326008)(6666004); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3264; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VEw9lphJqK/0CD1cC/xghcg0BiyjT9s9xJ30VA/rx9PfbeluaGDqu4DFIWOquBgbZMTOarhXNbEUxUWA9NTPNm1o6+kbBUtnnipFmqI75doQMCJu5gerD2SWhZRGgRtslUylXMZyoE1piUkMDH4IbEzknuUjfU8+Ct/mAkZRrl1ng8g2BawHGj4s5lF4VaRVesR0O9bXpPUmGIqS4+7X8Jor9oea+kONcEg5mtQ+xLRszOtmNb/1nZDrTa7LmTbz/Hbe/MuMo+8o+djxZD8zSIMT2RRAzNK2Az7CmDiHAXm1ZmLgAjarzpqjL9vf2UoeGyqgZrTsYjQqirAZJqKXN1Rif3/Uk/ysgr+XvglxI3DN9glAzfPuqkgjiz/t+JMvgQJaWJE0tL1ghtiPxDoiE0+0BTy9104DRjcsuPBpWwjb4GNe83WuOBw10TqiKlfIt2fieQX85aFRQ0WVJWXOj+llBmhbpShK6hIJ86CY7wmReN6y4PGXHbKh4EFt0iz9aeZd402NJdPW69seKGBc7w== X-MS-Exchange-AntiSpam-MessageData: ij7TLsStH/9idNUvO4LRMPr30nhMhSqy8IFV7KCyDQswKHf+r+E17HKlB9wo+hQq/Mdy0VfQMPu4ahjDdFQAGDJKP/Jk5K3JwXIhcHvqS5d1Br0WXZMBFmaCu0mD8BR/JuTM8auIvqNZOegS/ugrFA== X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4487b7-da4a-4c28-bb6e-08d7b3be5aea X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2020 15:30:44.9224 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2SVSqlbXAnAthpTUPLNCQmpuLtClCpMuZOs2MNBAhL01n0GZw1KWlImfNiWTFQSDzA8ZqqcNAFVRRHTvmrIcqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3264 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-17_10:2020-02-17, 2020-02-17 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 17, 2020 at 03:19:53PM +0000, Ferruh Yigit wrote: > On 2/17/2020 3:06 PM, Harman Kalra wrote: > > On Mon, Feb 17, 2020 at 02:54:13PM +0000, Ferruh Yigit wrote: > >> On 2/17/2020 2:35 PM, Harman Kalra wrote: > >>> On Mon, Feb 17, 2020 at 01:21:13PM +0000, Ferruh Yigit wrote: > >>>> External Email > >>>> > >>>> ---------------------------------------------------------------------- > >>>> On 2/15/2020 8:35 AM, Harman Kalra wrote: > >>>>> PTP functionality has been broken after a change in kernel > >>>>> where enum npc_kpu_lc_ltype is change to allow adjustment of > >>>>> LTYPE_MASK to detect all types of IP headers. > >>>>> Syncing the required changes in DPDK to fix the issue. > >>>> > >>>> Hi Harman, > >>>> > >>>> Can you please provide references for, > >>>> - What is the kernel commit causing the mentioned change? > >>>> - After this change which version of the kernel supported by the PMD? > >>> > >>> Hi Ferruh > >>> The kernel change I was refering to was in our internel kernel repo > >>> and those kernel changes have not been upstreamed yet. Currently its part > >>> of our marvell SDK version SDK-10.3.1.x. > >> > >> Got it, what is the dependency of the PMD to the Linux kernel? And does the PMD > >> works with upstream kernels? > > > > Yes, for basic functionality PMD works fine with upstreamed kernel but for > > supporting some advanced features like PTP, kernel changes are yet to be > > upstreamed. Our kernel driver for octeontx2 PMD: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_torvalds_linux_tree_master_drivers_net_ethernet_marvell_octeontx2_af&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V-7JdkxT_Z_SU6RrS37ys4UXudBQ_rrS5LRo&m=pXArrQOu5hyDcQfkwc34h1CkBsAQuEnZDcanbaM-GCQ&s=c7WM8a2aLkuXH5P5HpQofM1nmCAXufFYva5YVyEiYcM&e= > > Kernel upstreaming activity is not in same pace as DPDK. > > Is the marvell SDK code in a public repo? If so can you provide the details of > the kernel changes in that repo? It is good to have some reference on the matter. Marvel SDK is not in any public repo. But for reference internal kernel viz part of SDK version SDK-10.3.1.x with commit id "08705a860e2d3aebce44d6c357ed1c0ae71d3fd9" onwards will have the required changes. > > > > > Thanks > > Harman > >> > >>> > >>> Thanks > >>> Harman > >>> > >>>> > >>>>> > >>>>> Fixes: b5dc3140448e ("net/octeontx2: support base PTP") > >>>>> Cc: stable@dpdk.org > >>>>> > >>>>> Signed-off-by: Harman Kalra > >>>>> --- > >>>>> drivers/common/octeontx2/hw/otx2_npc.h | 4 ++-- > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>>> > >>>>> diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h > >>>>> index a0536e0ae..3dfc137a3 100644 > >>>>> --- a/drivers/common/octeontx2/hw/otx2_npc.h > >>>>> +++ b/drivers/common/octeontx2/hw/otx2_npc.h > >>>>> @@ -201,7 +201,8 @@ enum npc_kpu_lb_ltype { > >>>>> }; > >>>>> > >>>>> enum npc_kpu_lc_ltype { > >>>>> - NPC_LT_LC_IP = 1, > >>>>> + NPC_LT_LC_PTP = 1, > >>>>> + NPC_LT_LC_IP, > >>>>> NPC_LT_LC_IP_OPT, > >>>>> NPC_LT_LC_IP6, > >>>>> NPC_LT_LC_IP6_EXT, > >>>>> @@ -209,7 +210,6 @@ enum npc_kpu_lc_ltype { > >>>>> NPC_LT_LC_RARP, > >>>>> NPC_LT_LC_MPLS, > >>>>> NPC_LT_LC_NSH, > >>>>> - NPC_LT_LC_PTP, > >>>>> NPC_LT_LC_FCOE, > >>>>> }; > >>>>> > >>>>> > >>>> > >> >