From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7289DA0553; Mon, 17 Feb 2020 17:37:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6295B1D6F1; Mon, 17 Feb 2020 17:37:44 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 45CA61C037; Mon, 17 Feb 2020 17:37:42 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01HGaTt0014833; Mon, 17 Feb 2020 08:37:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=/a/nDr5Mv8GQtRtq0RT8hOFSqX9WFYXZtScOzI9ngO8=; b=jnXkFgGluNmEdzqKMvNfyyo2GGVbxwhgItn1VdwCJhJMaK7Rz4F4IQtxIQrIQOfnSkrI +cw6klglhJedlHPL+x8Acy5xu3Ol6SAwenTn85+2Po1lbA6YgWfcvkorez/mnbrO+yVd Q+EF5rc5JQO+B2Kd+1hzja7JwSjEel4O2Yq19a0XQgVKqb1LkhnHh0PuGr6hL+fwhc8r MGqiLrjgoUqq1Gout7Amg7XP+ls+YxXsao6cg4gmQKEDI76okSjt1mrCoAl6HtDoATBG B53cRsJP0AAfQuZKvOqtXAWLk4LjYsGHrdSRX2GTvonFr+2qkNd5tTFn9JyYoKCnGfqF kA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2y6evv81tb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Feb 2020 08:37:41 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 17 Feb 2020 08:37:39 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 17 Feb 2020 08:37:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTjVt+DOhb7BU7kd6vx3ea+MWReb4FiOUTKwDt8YxSD6bBEdsWLgIZnAuRzRzmRgS5UNAvLqqPV/bJCTj1Hsw9JKwABG7RRJA9l9CNRPrM33N5tK4vLK6F8BNCpOTEehGBGss5+kbjNjt8R3fGtbpWa8iB1WVu8Q2268kCkl0Bln/jMVlZvqSjtaUCYp9kJGFtY1cJVbeyggEgsF60NTuyenBGAkpmEDi/ZTaUCeASe/oSClnvZQurpXHryPsxrBMkjiyMQ7SfHzhpBsUXI4PQC6Q8ARhisn+zoRgTAP74e8WWyFChnuUAKh0Xnos1rpBlDh2J+f+lWzqZO64Ca/lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/a/nDr5Mv8GQtRtq0RT8hOFSqX9WFYXZtScOzI9ngO8=; b=NbIO1yKIya/mdJC1vVtSA0IzjN0BWl67sp5HbnapoqK87vQMVegEh9xICNpjKy6TuIyFRjj7wMQngWEmgN6i2hT/t7DdHH0q0NCUqY23m9/0IsO77zYzJyknhEDnkrLb1INqrRhH2IKn7nw/Gp0P2Kz+VigwcZQPbGuwXMy9koyTEu94h/peMI7OR6zZ5h41e6aZR2brEDgdTmbP2BkzvtEqTGrLayJMjRglyZmpnNVqMxHVIhUtLignBbp7kHnYrqmoRuv453B66dJ9tmlwIkB6u53uLXPIo1tlvq6+YpmktD8/atZIf40dxxFaSj6kHGGE8/2A+8zPNPCKuEzVow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/a/nDr5Mv8GQtRtq0RT8hOFSqX9WFYXZtScOzI9ngO8=; b=et1+vWhbKRrVSl7r2Bi7KOGFADhAsG4GYBbLXQBwnSKHkdZL2BgKUTeXJRv9UCz94K+fVNblwf8EFhUhwNGAJ03ggj5SCtz0NSm3CEB9ZbtLepQ4/DgDULFCQCmm6IsE06G7uWtK3LBzUxPE6kBQHBlWsH8epVauxcmikn161e8= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.20.19) by MN2PR18MB3639.namprd18.prod.outlook.com (20.180.246.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.27; Mon, 17 Feb 2020 16:37:37 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::6de0:6ead:9fc:5beb]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::6de0:6ead:9fc:5beb%3]) with mapi id 15.20.2729.032; Mon, 17 Feb 2020 16:37:37 +0000 Date: Mon, 17 Feb 2020 22:07:22 +0530 From: Harman Kalra To: Ferruh Yigit CC: Jerin Jacob , Vamsi Attunuru , , Message-ID: <20200217163721.GA153283@outlook.office365.com> References: <1581755704-15546-1-git-send-email-hkalra@marvell.com> <194bbbb5-7af3-2bb8-ef0b-e2a571a58efe@intel.com> <20200217143437.GA23753@outlook.office365.com> <842f21a6-8043-0608-0428-98ca07930cbf@intel.com> <20200217150648.GB23753@outlook.office365.com> <7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com> <20200217153027.GA110928@outlook.office365.com> <52b53dc5-8f2a-f635-0fe1-76386d9459b7@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52b53dc5-8f2a-f635-0fe1-76386d9459b7@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-ClientProxiedBy: BM1PR0101CA0041.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::27) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) MIME-Version: 1.0 Received: from outlook.office365.com (115.113.156.2) by BM1PR0101CA0041.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.24 via Frontend Transport; Mon, 17 Feb 2020 16:37:35 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 136934a9-70a0-4a54-c117-08d7b3c7b2a5 X-MS-TrafficTypeDiagnostic: MN2PR18MB3639: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0316567485 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(199004)(189003)(316002)(7696005)(52116002)(81166006)(81156014)(8936002)(6916009)(6666004)(8676002)(54906003)(33656002)(66946007)(66476007)(66556008)(2906002)(9686003)(1076003)(86362001)(4326008)(55016002)(6506007)(55236004)(53546011)(26005)(16526019)(966005)(5660300002)(956004)(478600001)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3639; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MinmHxHVsyebgWAidZBBUCmtoeLLbojJsaLRgWBiGYavBOVNmWsQw8hqJf0q1l0M4sZ3a+CNL1VeU5bfAB0TeVmzO5TAJBIb54UJikMqMOf/pHH6nahj6i2412AT8QV/FmZFqJa5UhzDDSzFoiIKCLE5pF8GI0K1XOdN9LHcAMzmhxlu/s/0j6ddaFqLgylzF5IE3sKRt2SF7q43YkUfFxvlqhnmx6OWZss9cW/DCHE3nkNM7heUlcB1dIzbCLJwSR1JCIqew5DHmd3FECqej5BejyRPy9DRRN+o55PXtkI0eHxyShZ+vbWd6psj8QxXAf+kN5Fu5SJwOgO/tIbALEQMI1gAKw2X4k5YJiZtqrfJRgHCtVrJi+ukFvBaMFYsjsiqvvZmkidQo7z5iqhrSHdNub2fFDppfzbHDU6WfjXGuDbu45YsuSqN9Aim423zY8pe/EiZD+MOs3zVTk9sjUIst5cYWSls7XO67KbE+FF0FEaVhroD0T1g3ALIhKCvnrqaQNDWJagfxGuXpExxuw== X-MS-Exchange-AntiSpam-MessageData: Hyej3ZdRKohAeQf7gUSrkX8oWwkaCkXs1nztrtd1OCCD5YSjCtRI/eb/pKm4lq0Hm2t0JAonJA8KCKKd3F7POyzoiVEPUe15GVJEzsGkvi8MLaq/64xGinnIHyxlw2o/bRYu9wfVHGNkMsLjG8ZNWA== X-MS-Exchange-CrossTenant-Network-Message-Id: 136934a9-70a0-4a54-c117-08d7b3c7b2a5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2020 16:37:37.6074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i5tXSgHXiTEmvSNivbFHTAdUhNh6y4wU5gA1vZPYW9Ar+b0ecXtaSs2lizsPoQbqXbZDaGvK6Uxc35N3XEFMYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3639 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-17_10:2020-02-17, 2020-02-17 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 17, 2020 at 04:17:53PM +0000, Ferruh Yigit wrote: > On 2/17/2020 3:30 PM, Harman Kalra wrote: > > On Mon, Feb 17, 2020 at 03:19:53PM +0000, Ferruh Yigit wrote: > >> On 2/17/2020 3:06 PM, Harman Kalra wrote: > >>> On Mon, Feb 17, 2020 at 02:54:13PM +0000, Ferruh Yigit wrote: > >>>> On 2/17/2020 2:35 PM, Harman Kalra wrote: > >>>>> On Mon, Feb 17, 2020 at 01:21:13PM +0000, Ferruh Yigit wrote: > >>>>>> External Email > >>>>>> > >>>>>> ---------------------------------------------------------------------- > >>>>>> On 2/15/2020 8:35 AM, Harman Kalra wrote: > >>>>>>> PTP functionality has been broken after a change in kernel > >>>>>>> where enum npc_kpu_lc_ltype is change to allow adjustment of > >>>>>>> LTYPE_MASK to detect all types of IP headers. > >>>>>>> Syncing the required changes in DPDK to fix the issue. > >>>>>> > >>>>>> Hi Harman, > >>>>>> > >>>>>> Can you please provide references for, > >>>>>> - What is the kernel commit causing the mentioned change? > >>>>>> - After this change which version of the kernel supported by the PMD? > >>>>> > >>>>> Hi Ferruh > >>>>> The kernel change I was refering to was in our internel kernel repo > >>>>> and those kernel changes have not been upstreamed yet. Currently its part > >>>>> of our marvell SDK version SDK-10.3.1.x. > >>>> > >>>> Got it, what is the dependency of the PMD to the Linux kernel? And does the PMD > >>>> works with upstream kernels? > >>> > >>> Yes, for basic functionality PMD works fine with upstreamed kernel but for > >>> supporting some advanced features like PTP, kernel changes are yet to be > >>> upstreamed. Our kernel driver for octeontx2 PMD: > >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_torvalds_linux_tree_master_drivers_net_ethernet_marvell_octeontx2_af&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V-7JdkxT_Z_SU6RrS37ys4UXudBQ_rrS5LRo&m=pXArrQOu5hyDcQfkwc34h1CkBsAQuEnZDcanbaM-GCQ&s=c7WM8a2aLkuXH5P5HpQofM1nmCAXufFYva5YVyEiYcM&e= > >>> Kernel upstreaming activity is not in same pace as DPDK. > >> > >> Is the marvell SDK code in a public repo? If so can you provide the details of > >> the kernel changes in that repo? It is good to have some reference on the matter. > > > > Marvel SDK is not in any public repo. But for reference internal kernel viz part of > > SDK version SDK-10.3.1.x with commit id "08705a860e2d3aebce44d6c357ed1c0ae71d3fd9" > > onwards will have the required changes. > > If it is not public, the commit id won't help much. Would you be OK if I add > something like following while merging: > > The kernel side changes are exists in marvell SDK version SDK-10.3.1.x. I am sorry, one correction kernel side changes exists in SDK version SDK-10.3.2.x and not in SDK-10.3.1.x Please feel free to mention SDK version SDK-10.3.2.x > > >> > >>> > >>> Thanks > >>> Harman > >>>> > >>>>> > >>>>> Thanks > >>>>> Harman > >>>>> > >>>>>> > >>>>>>> > >>>>>>> Fixes: b5dc3140448e ("net/octeontx2: support base PTP") > >>>>>>> Cc: stable@dpdk.org > >>>>>>> > >>>>>>> Signed-off-by: Harman Kalra > >>>>>>> --- > >>>>>>> drivers/common/octeontx2/hw/otx2_npc.h | 4 ++-- > >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>>>>> > >>>>>>> diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h > >>>>>>> index a0536e0ae..3dfc137a3 100644 > >>>>>>> --- a/drivers/common/octeontx2/hw/otx2_npc.h > >>>>>>> +++ b/drivers/common/octeontx2/hw/otx2_npc.h > >>>>>>> @@ -201,7 +201,8 @@ enum npc_kpu_lb_ltype { > >>>>>>> }; > >>>>>>> > >>>>>>> enum npc_kpu_lc_ltype { > >>>>>>> - NPC_LT_LC_IP = 1, > >>>>>>> + NPC_LT_LC_PTP = 1, > >>>>>>> + NPC_LT_LC_IP, > >>>>>>> NPC_LT_LC_IP_OPT, > >>>>>>> NPC_LT_LC_IP6, > >>>>>>> NPC_LT_LC_IP6_EXT, > >>>>>>> @@ -209,7 +210,6 @@ enum npc_kpu_lc_ltype { > >>>>>>> NPC_LT_LC_RARP, > >>>>>>> NPC_LT_LC_MPLS, > >>>>>>> NPC_LT_LC_NSH, > >>>>>>> - NPC_LT_LC_PTP, > >>>>>>> NPC_LT_LC_FCOE, > >>>>>>> }; > >>>>>>> > >>>>>>> > >>>>>> > >>>> > >> >