From: taox.zhu@intel.com
To: jerinj@marvell.com, ndabilpuram@marvell.com, vattunuru@marvell.com
Cc: dev@dpdk.org, Tao Zhu <taox.zhu@intel.com>
Subject: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
Date: Mon, 17 Feb 2020 16:43:45 +0000 [thread overview]
Message-ID: <20200217164345.6207-1-taox.zhu@intel.com> (raw)
From: Tao Zhu <taox.zhu@intel.com>
Change the definition of C99 style to C90 style.
compile log as below:
otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
‘for’ loop initial declarations are only allowed in C99 mode
for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
^
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
note: use option -std=c99 or -std=gnu99 to compile your code
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
cc1: error: unrecognized command line option \
"-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
make[6]: *** [otx2_mempool_ops.o] Error 1
make[5]: *** [octeontx2] Error 2
make[4]: *** [mempool] Error 2
Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
Signed-off-by: Tao Zhu <taox.zhu@intel.com>
---
drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
index 6b55447..ac2d618 100644
--- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
+++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
@@ -754,6 +754,7 @@
size_t total_elt_sz;
uint8_t set;
size_t off;
+ int i;
if (iova == RTE_BAD_IOVA)
return -EINVAL;
@@ -787,7 +788,7 @@
otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRIu64"",
(uint64_t)max_objs, (uint64_t)(len / total_elt_sz));
otx2_npa_dbg("L1D set distribution :");
- for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
+ for (i = 0; i < OTX2_L1D_NB_SETS; i++)
otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i,
distribution[i]);
--
1.8.3.1
next reply other threads:[~2020-02-17 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:43 taox.zhu [this message]
2020-02-17 11:19 ` David Marchand
2020-02-17 14:57 ` David Marchand
2020-02-17 18:04 ` Jeremy Plsek
2020-02-17 18:28 ` Thomas Monjalon
2020-02-17 13:06 ` Jerin Jacob
2020-02-17 14:57 ` David Marchand
2020-02-17 18:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217164345.6207-1-taox.zhu@intel.com \
--to=taox.zhu@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).