From: Bruce Richardson <bruce.richardson@intel.com>
To: Aaron Conole <aconole@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
Date: Mon, 17 Feb 2020 16:46:05 +0000 [thread overview]
Message-ID: <20200217164605.GA871@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <f7t5zg5w4g2.fsf@dhcp-25.97.bos.redhat.com>
On Mon, Feb 17, 2020 at 11:42:37AM -0500, Aaron Conole wrote:
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > The kernel modules are not built by default since below commit.
> > The Travis CI matrix can be simplified
> > by removing the redundant option enable_kmods=false,
> > and by removing some jobs which become redundant.
> >
> > Note: there is no benefit in checking kmods in Travis Ubuntu.
> > Anyway different kernel versions and distributions are needed,
> > and the Technical Board is looking at moving the Linux kmods
> > out of this repository.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> Looks good to me, but do you think there's no benefit to even compiling
> the kernel modules that get shipped?
>
> Otherwise,
> Acked-by: Aaron Conole <aconole@redhat.com>
>
>
I think we need one compile that turns them on to test.
/Bruce
next prev parent reply other threads:[~2020-02-17 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 11:35 [dpdk-dev] [PATCH 0/2] improve Travis coverage Thomas Monjalon
2020-02-17 11:35 ` [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-17 14:06 ` Thomas Monjalon
2020-02-17 16:42 ` Aaron Conole
2020-02-17 16:46 ` Bruce Richardson [this message]
2020-02-17 18:00 ` Thomas Monjalon
2020-02-17 11:35 ` [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
2020-02-17 18:00 ` Aaron Conole
2020-02-17 21:19 ` Thomas Monjalon
2020-02-17 21:38 ` Aaron Conole
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 0/2] improve Travis coverage Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
2020-02-18 22:36 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217164605.GA871@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).