From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5FECA054F; Tue, 18 Feb 2020 10:40:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C11A71D8CD; Tue, 18 Feb 2020 10:40:19 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BA8B11C012 for ; Tue, 18 Feb 2020 10:40:18 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 01:40:17 -0800 X-IronPort-AV: E=Sophos;i="5.70,456,1574150400"; d="scan'208";a="228685444" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.88.201]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Feb 2020 01:40:15 -0800 Date: Tue, 18 Feb 2020 09:40:12 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, ray.kinsella@intel.com, nhorman@tuxdriver.com, bluca@debian.org, david.marchand@redhat.com, ktraynor@redhat.com Message-ID: <20200218094012.GA875@bricha3-MOBL.ger.corp.intel.com> References: <44659287.fMDQidcC6G@xps> <20200217234402.2235904-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217234402.2235904-1-thomas@monjalon.net> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] build: fix soname for experimental libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 18, 2020 at 12:44:02AM +0100, Thomas Monjalon wrote: > Because of an original mistake in ABI numbering, > and a temporary workaround for ABI 20, > for experimental libs, numbering would lead to consider > ABI 20.1 > ABI 21.0 > > Before this patch: > > DPDK 19.11: ABI version 0.200 and soname 0.20 > DPDK 20.02: ABI version 0.2001 and soname 0.201 > Numbers are increasing, that's fine. > For the next major ABI, back to normal numbering: > DPDK 20.11: ABI version 0.210 and soname 0.21 > Numbers are decreasing! > > After this patch: > > DPDK 19.11: ABI version 0.200 and soname 0.20 > DPDK 20.02: ABI version 0.201 and soname 0.20 > DPDK 20.11: ABI version 0.210 and soname 0.21 > > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility") > > Signed-off-by: Thomas Monjalon > --- > config/meson.build | 8 ++++---- > mk/rte.lib.mk | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/config/meson.build b/config/meson.build > index 6c46767e3e..e7cd74e2c2 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -27,12 +27,12 @@ abi_version = run_command(find_program('cat', 'more'), > # and the filename suffix as 0.majorminor versions, > # e.g. v20.1 => librte_stable.so.20.1, librte_experimental.so.0.201 > # sonames => librte_stable.so.20, librte_experimental.so.0.20 > -# e.g. v20.0.1 => librte_stable.so.20.0.1, librte_experimental.so.0.2001 > -# sonames => librte_stable.so.20.0, librte_experimental.so.0.200 > +# e.g. v20.0.1 => librte_stable.so.20.0.1, librte_experimental.so.0.201 > +# sonames => librte_stable.so.20.0, librte_experimental.so.0.20 > abi_va = abi_version.split('.') > stable_so_version = abi_va.length() == 2 ? abi_va[0] : abi_va[0] + '.' + abi_va[1] > -experimental_abi_version = '0.' + ''.join(abi_va) > -experimental_so_version = '0.' + ''.join(stable_so_version.split('.')) > +experimental_abi_version = '0.' + ''.join([abi_va[0], abi_va[2]]) > +experimental_so_version = '0.' + ''.join([abi_va[0]]) > My concern about this is that it will break, or rather need to be changed again for the 20.11 release. While I see the numbering as not-ideal in terms of version numbers, the existing scheme was originally designed to work with either 3-digit or 2-digit version numbers. /Bruce