From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson
Date: Tue, 18 Feb 2020 14:54:13 +0000 [thread overview]
Message-ID: <20200218145413.GA968@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <3570090.TLkxdtWsSY@xps>
On Tue, Feb 18, 2020 at 03:26:47PM +0100, Thomas Monjalon wrote:
> 18/02/2020 01:02, Dmitry Kozlyuk:
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > +# MS linker requires special treatment.
> > +# FIXME: use cc.get_linker_id() with Meson >= 0.54
> > +is_ms_linker = is_windows and (cc.get_id() == 'clang')
>
> Please could you replace this FIXME with an actual fix in meson.build?
>
Best not to at this point, as even with an explicit version check for the
new function, you can still get a warning from meson about using functions
from versions greater than baseline. In this release we have removed most,
if not all, existing warnings and I'd rather not add any back in.
Suggest replacing the fixme with a NOTE or TODO, since it's not a bug that
needs to be fixed, rather a future enhancement once we update our meson
baseline.
/Bruce
next prev parent reply other threads:[~2020-02-18 14:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 0:02 [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support Dmitry Kozlyuk
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 1/7] eal: introduce portable format attribute Dmitry Kozlyuk
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 2/7] eal/windows: use lowercase filenames for system headers Dmitry Kozlyuk
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 3/7] eal/windows: support builing with MinGW-w64 Dmitry Kozlyuk
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson Dmitry Kozlyuk
2020-02-18 14:26 ` Thomas Monjalon
2020-02-18 14:54 ` Bruce Richardson [this message]
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 5/7] build: add cross-file for MinGW-w64 Dmitry Kozlyuk
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 6/7] doc: guide for Windows build using MinGW-w64 Dmitry Kozlyuk
2020-02-18 21:27 ` William Tu
2020-02-18 0:02 ` [dpdk-dev] [PATCH v3 7/7] build: fix linker warnings with Clang on Windows Dmitry Kozlyuk
2020-02-18 21:16 ` [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support William Tu
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 " Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute Dmitry Kozlyuk
2020-03-12 22:33 ` Thomas Monjalon
2020-03-13 23:38 ` Dmitry Kozlyuk
2020-03-15 8:36 ` Thomas Monjalon
2020-03-16 10:54 ` Bruce Richardson
2020-03-16 11:02 ` Bruce Richardson
2020-03-16 11:14 ` Thomas Monjalon
2020-03-16 11:18 ` Bruce Richardson
2020-03-16 11:35 ` Bruce Richardson
2020-03-16 14:27 ` Thomas Monjalon
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 2/7] eal/windows: use lowercase filenames for system headers Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 3/7] eal/windows: support builing with MinGW-w64 Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 4/7] build: MinGW-w64 support for Meson Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 5/7] build: add cross-file for MinGW-w64 Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 6/7] doc: guide for Windows build using MinGW-w64 Dmitry Kozlyuk
2020-02-27 4:25 ` [dpdk-dev] [PATCH v4 7/7] build: fix linker warnings with Clang on Windows Dmitry Kozlyuk
2020-03-11 17:22 ` [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support William Tu
2020-03-18 0:24 ` Thomas Monjalon
2020-03-11 22:36 ` Kadam, Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218145413.GA968@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).