From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8CE6A054F; Tue, 18 Feb 2020 15:54:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 078291BFFE; Tue, 18 Feb 2020 15:54:20 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D2A9A1BFFD for <dev@dpdk.org>; Tue, 18 Feb 2020 15:54:18 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 06:54:17 -0800 X-IronPort-AV: E=Sophos;i="5.70,456,1574150400"; d="scan'208";a="228752804" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.87.115]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Feb 2020 06:54:16 -0800 Date: Tue, 18 Feb 2020 14:54:13 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org Message-ID: <20200218145413.GA968@bricha3-MOBL.ger.corp.intel.com> References: <20200218000229.86621-1-dmitry.kozliuk@gmail.com> <20200218000229.86621-5-dmitry.kozliuk@gmail.com> <3570090.TLkxdtWsSY@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3570090.TLkxdtWsSY@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Feb 18, 2020 at 03:26:47PM +0100, Thomas Monjalon wrote: > 18/02/2020 01:02, Dmitry Kozlyuk: > > --- a/config/meson.build > > +++ b/config/meson.build > > +# MS linker requires special treatment. > > +# FIXME: use cc.get_linker_id() with Meson >= 0.54 > > +is_ms_linker = is_windows and (cc.get_id() == 'clang') > > Please could you replace this FIXME with an actual fix in meson.build? > Best not to at this point, as even with an explicit version check for the new function, you can still get a warning from meson about using functions from versions greater than baseline. In this release we have removed most, if not all, existing warnings and I'd rather not add any back in. Suggest replacing the fixme with a NOTE or TODO, since it's not a bug that needs to be fixed, rather a future enhancement once we update our meson baseline. /Bruce