From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, oda@valinux.co.jp, yinan.wang@intel.com,
tiwei.bie@intel.com, amorenoz@redhat.com,
david.marchand@redhat.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig
Date: Tue, 18 Feb 2020 18:22:40 +0100 [thread overview]
Message-ID: <20200218172240.558516-3-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20200218172240.558516-1-maxime.coquelin@redhat.com>
Ethdev's .dev_configure callback can be called multiple
time during a device life-time, but Vhost makes the
wrong assumption that it is not the case and try to
setup again the device on reconfiguration.
This patch ensures the device hasn't been already setup
before proceeding.
Fixes: 3d01b759d267 ("net/vhost: delay driver setup")
Reported-by: Yinan Wang <yinan.wang@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Tested-by: Yinan Wang <yinan.wang@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/vhost/rte_eth_vhost.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 4a7b1b608c..458ed58f5f 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -876,6 +876,11 @@ vhost_driver_setup(struct rte_eth_dev *eth_dev)
unsigned int numa_node = eth_dev->device->numa_node;
const char *name = eth_dev->device->name;
+ /* Don't try to setup again if it has already been done. */
+ list = find_internal_resource(internal->iface_name);
+ if (list)
+ return 0;
+
list = rte_zmalloc_socket(name, sizeof(*list), 0, numa_node);
if (list == NULL)
return -1;
--
2.24.1
next prev parent reply other threads:[~2020-02-18 17:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 17:22 [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup Maxime Coquelin
2020-02-18 17:22 ` [dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path Maxime Coquelin
2020-02-19 3:05 ` Tiwei Bie
2020-02-18 17:22 ` Maxime Coquelin [this message]
2020-02-19 3:44 ` [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig Tiwei Bie
2020-02-19 8:17 ` Maxime Coquelin
2020-02-19 22:17 ` Itsuro ODA
2020-02-18 17:25 ` [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup Maxime Coquelin
2020-02-18 22:37 ` Itsuro ODA
2020-02-19 10:16 ` Maxime Coquelin
2020-02-19 10:18 ` Maxime Coquelin
2020-02-19 11:17 ` Kevin Traynor
2020-02-19 10:23 ` Maxime Coquelin
-- strict thread matches above, loose matches on Subject: below --
2020-02-18 14:35 Maxime Coquelin
2020-02-18 14:35 ` [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig Maxime Coquelin
2020-02-18 15:26 ` Maxime Coquelin
2020-02-18 15:27 ` Wang, Yinan
2020-02-18 16:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218172240.558516-3-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=amorenoz@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=oda@valinux.co.jp \
--cc=tiwei.bie@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).