From: David Wilder <dwilder@us.ibm.com>
To: aconole@redhat.com, maicolgabriel@hotmail.com,
thomas@monjalon.net, ferruh.yigit@intel.com,
arybchenko@solarflare.com
Cc: dev@dpdk.org, ruifeng.wang@arm.com, david.marchand@redhat.com,
drc@linux.vnet.ibm.com, wilder@us.ibm.com
Subject: [dpdk-dev] [PATCH v2 1/3] eal/linux: select iova-mode va with no-huge option
Date: Tue, 18 Feb 2020 17:10:05 -0800 [thread overview]
Message-ID: <20200219011007.8611-2-dwilder@us.ibm.com> (raw)
In-Reply-To: <20200219011007.8611-1-dwilder@us.ibm.com>
If --no-huge is set and iova-mode has not been specified force VA mode.
If --no-huge and --iova-mode=PA is requested error out as this is
an impossible configuration.
Signed-off-by: David Wilder <dwilder@us.ibm.com>
---
lib/librte_eal/linux/eal/eal.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 9530ee55f..d3a0a1731 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1062,9 +1062,16 @@ rte_eal_init(int argc, char **argv)
/* if no EAL option "--iova-mode=<pa|va>", use bus IOVA scheme */
if (internal_config.iova_mode == RTE_IOVA_DC) {
+
/* autodetect the IOVA mapping mode */
enum rte_iova_mode iova_mode = rte_bus_get_iommu_class();
+ if (iova_mode == RTE_IOVA_PA && !rte_eal_has_hugepages()) {
+ iova_mode = RTE_IOVA_VA;
+ RTE_LOG(WARNING, EAL, "Some buses want 'PA' but forcing 'VA' because --no-huge is requested.\n");
+ RTE_LOG(WARNING, EAL, "Not all buses may be able to initialize.\n");
+ }
+
if (iova_mode == RTE_IOVA_DC) {
RTE_LOG(DEBUG, EAL, "Buses did not request a specific IOVA mode.\n");
@@ -1111,6 +1118,13 @@ rte_eal_init(int argc, char **argv)
internal_config.iova_mode;
}
+ if (rte_eal_iova_mode() == RTE_IOVA_PA &&
+ rte_eal_has_hugepages() == 0) {
+ rte_eal_init_alert("Cannot use IOVA as 'PA' with --no-huge");
+ rte_errno = EINVAL;
+ return -1;
+ }
+
if (rte_eal_iova_mode() == RTE_IOVA_PA && !phys_addrs) {
rte_eal_init_alert("Cannot use IOVA as 'PA' since physical addresses are not available");
rte_errno = EINVAL;
--
2.25.0
next prev parent reply other threads:[~2020-02-19 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 1:10 [dpdk-dev] [PATCH v2 0/3] add travis ci support for ppc64le David Wilder
2020-02-19 1:10 ` David Wilder [this message]
2020-02-19 1:10 ` [dpdk-dev] [PATCH v2 2/3] devtools: allow test-null.sh to run on ppc64le David Wilder
2020-02-19 1:10 ` [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le David Wilder
2020-02-19 7:55 ` Thomas Monjalon
2020-02-19 13:46 ` David Marchand
2020-02-19 20:32 ` dwilder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219011007.8611-2-dwilder@us.ibm.com \
--to=dwilder@us.ibm.com \
--cc=aconole@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@intel.com \
--cc=maicolgabriel@hotmail.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).