DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	ray.kinsella@intel.com, bluca@debian.org,
	david.marchand@redhat.com, ktraynor@redhat.com, dev@dpdk.org
Subject: Re: [dpdk-dev] ABI version of experimental libraries
Date: Wed, 19 Feb 2020 16:17:59 -0500	[thread overview]
Message-ID: <20200219211759.GC357121@hmswarspite.think-freely.org> (raw)
In-Reply-To: <5254976.hdfAi7Kttb@xps>

On Wed, Feb 19, 2020 at 01:43:01PM +0100, Thomas Monjalon wrote:
> 19/02/2020 12:43, Neil Horman:
> > On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote:
> > > 18/02/2020 10:42, Bruce Richardson:
> > > > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote:
> > > > > Hi,
> > > > > 
> > > > > I would like to remind everybody our mistake when defining ABI versions.
> > > > > It has been "fixed" in this commit:
> > > > > http://git.dpdk.org/dpdk/commit/?id=f26c2b39
> > > > > 
> > > > > Please let's think about the consequence for the experimental libraries.
> > > > > 
> > > > > In DPDK 19.11, we use the ABI version 0.200 with soname 0.20 In DPDK
> > > > > 20.02, we use the ABI version 0.2001 with soname 0.201 Numbers are
> > > > > increasing, that's fine.  When we'll switch to the new major ABI and use
> > > > > a normal numbering: In DPDK 20.11, we will use the ABI version 0.210 with
> > > > > soname 0.21 Numbers are dropping.
> > > > > 
> > > > > In short, for experimental libs, ABI 20.1 > ABI 21.0
> > > > > 
> > > > > Are we OK with this or do we prefer reverting to normal numbering for
> > > > > experimental libraries in DPDK 20.02?
> > > > > 
> > > > Personally, I would not be too concerned about the verions of experimental
> > > > libs, so long as they don't conflict across versions and have some
> > > > similarity to the major ABI version for the release.
> > > 
> > > You think sorting of the version numbers is not important?
> > > If we don't care comparing experimental version numbers,
> > > then OK, let's drop this patch. But please we need a small vote.
> > > 
> > > Note: there would be no problem if we did not vote for having
> > > a special numbering for pure experimental libraries (I am still against).
> > > 
> > I don't understand.  Why would we change the ABI_VERSION at all in an LTS release at
> > all?  This operation is meant to take an an experimental API and mark it as
> > stable by promoting its version number to the next major releases number.  As
> > such, in the LTS release, we should keep the soname the same, as there should be
> > no other ABI changes in the promoted API.
> 
> The library version number is updated because we add new symbols.
But thats a matter of policy (and possibly build mechanics).  Not saying agree
with this approach necessecarily (as I've not fully thought it through), but we
could make room in the policy for this eventuality.

Neil
> 
> 
> 

      parent reply	other threads:[~2020-02-19 21:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 23:15 Thomas Monjalon
2020-02-17 23:44 ` [dpdk-dev] [PATCH] build: fix soname for " Thomas Monjalon
2020-02-18  9:40   ` Bruce Richardson
2020-02-18  9:47     ` Thomas Monjalon
2020-02-18  9:42 ` [dpdk-dev] ABI version of " Bruce Richardson
2020-02-18  9:50   ` Thomas Monjalon
2020-02-18 10:36     ` Kinsella, Ray
2020-02-20 19:50       ` Ferruh Yigit
2020-02-20 19:54         ` [dpdk-dev] [PATCH] build: fix experimental library versioning Ferruh Yigit
2020-02-20 22:14           ` Luca Boccassi
2020-02-21 12:36           ` Ray Kinsella
2020-02-21 15:24           ` David Marchand
2020-02-21 15:34             ` Ferruh Yigit
2020-02-21 16:41           ` David Marchand
2020-02-19 11:43     ` [dpdk-dev] ABI version of experimental libraries Neil Horman
2020-02-19 12:43       ` Thomas Monjalon
2020-02-19 13:50         ` Ray Kinsella
2020-02-21 16:57           ` Thomas Monjalon
2020-02-24  9:32             ` Ray Kinsella
2020-02-19 21:17         ` Neil Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219211759.GC357121@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=ray.kinsella@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).