From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57377A0555; Thu, 20 Feb 2020 07:12:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C6981B951; Thu, 20 Feb 2020 07:12:45 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E181658C4; Thu, 20 Feb 2020 07:12:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2020 22:12:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,463,1574150400"; d="scan'208";a="434728338" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 19 Feb 2020 22:12:40 -0800 Date: Thu, 20 Feb 2020 14:11:01 +0800 From: Ye Xiaolong To: taox.zhu@intel.com Cc: qiming.yang@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com, stable@dpdk.org Message-ID: <20200220061101.GC36983@intel.com> References: <20200219101712.9525-1-taox.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219101712.9525-1-taox.zhu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice: fix queue bind MSI-X interrupt error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/19, taox.zhu@intel.com wrote: >From: Zhu Tao > >To bind a queue to an MSI-X interrupt, need to set some register. >The register consists of many parts, each of which has several >bits; therefore, the shift operator '<<' was used; so the operator >'<' in the code should be '<<'. > >Old code adds 1 on even MSI-X interrupt vector index used by queue, >resulting in interrupt mapping error. > >Fixes: 65dfc889d8 ("net/ice: support Rx queue interruption") >Cc: stable@dpdk.org > >Signed-off-by: Zhu Tao >--- > drivers/net/ice/ice_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c >index 8e9369e0a..85ef83e92 100644 >--- a/drivers/net/ice/ice_ethdev.c >+++ b/drivers/net/ice/ice_ethdev.c >@@ -2605,9 +2605,9 @@ __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect, > for (i = 0; i < nb_queue; i++) { > /*do actual bind*/ > val = (msix_vect & QINT_RQCTL_MSIX_INDX_M) | >- (0 < QINT_RQCTL_ITR_INDX_S) | QINT_RQCTL_CAUSE_ENA_M; >+ (0 << QINT_RQCTL_ITR_INDX_S) | QINT_RQCTL_CAUSE_ENA_M; > val_tx = (msix_vect & QINT_TQCTL_MSIX_INDX_M) | >- (0 < QINT_TQCTL_ITR_INDX_S) | QINT_TQCTL_CAUSE_ENA_M; >+ (0 << QINT_TQCTL_ITR_INDX_S) | QINT_TQCTL_CAUSE_ENA_M; > > PMD_DRV_LOG(INFO, "queue %d is binding to vect %d", > base_queue + i, msix_vect); >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.