From: Tiwei Bie <tiwei.bie@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: use common macros for min/max
Date: Sat, 22 Feb 2020 07:50:20 +0800 [thread overview]
Message-ID: <20200221235020.GA103347@___> (raw)
In-Reply-To: <3026524.oiGErgHkdL@xps>
On Fri, Feb 21, 2020 at 07:29:13PM +0100, Thomas Monjalon wrote:
> 20/02/2020 03:52, Tiwei Bie:
> > On Wed, Feb 19, 2020 at 11:39:22AM +0100, Thomas Monjalon wrote:
> > > The macros RTE_MIN and RTE_MAX can be used in DPDK applications.
>
> Only RTE_MIN is used in this patch. The title is wrong as well.
Make sense! The commit log should describe what's changed
by the patch exactly.
>
>
> > > This change implies fixing the sign of used_len as size_t
> > > as defined in vhost_strcpy_pad().
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > > examples/vhost_blk/blk.c | 4 ++--
> > > examples/vhost_blk/vhost_blk.h | 2 --
> > > examples/vhost_blk/vhost_blk_compat.c | 2 +-
> > > 3 files changed, 3 insertions(+), 5 deletions(-)
> >
> > Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
>
>
>
next prev parent reply other threads:[~2020-02-21 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 10:39 Thomas Monjalon
2020-02-20 2:52 ` Tiwei Bie
2020-02-21 18:29 ` Thomas Monjalon
2020-02-21 23:50 ` Tiwei Bie [this message]
2020-04-07 13:36 ` Maxime Coquelin
2020-04-10 14:42 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221235020.GA103347@___ \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).