From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48C8BA055E; Wed, 26 Feb 2020 01:55:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63D9C1BF8D; Wed, 26 Feb 2020 01:55:55 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 07AFD2C02 for ; Wed, 26 Feb 2020 01:55:52 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id p14so505196pfn.4 for ; Tue, 25 Feb 2020 16:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cptlI/PcCxrySlTOIG8YBa64xYJOzq0OhLcumR88bxI=; b=SSdwow7DCH34JGYP22A1nNZBrs+C46O3N6EHLpgjxMvL2jbXoeolQac3lMNTj/Ccok kamSkrUyJSWHNuZHEgZg37zY7Rvy4IKsfJ/3V0vFWc1RVCDCkDZ8eM9gBkFR73uo05Lv tqSJz165W2DzyfKfEVsUW+cDEs/ZwQHu2EUmYEyNF6MKXyDFIhIkM9ETLuuJfeCSpaeQ JcCfBitU7CZXryxQzD4NyRxEWjIZa7mI+RO1HTaA3jrcf8dmsdvf+deUxqqLTLuDAXX/ cGI/VnupbOxsL8EOCITm/1a/wd+I8Vvi8dwhI2c7K8yD5s+NszJQeys90mabQJe3t9Qy EGwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cptlI/PcCxrySlTOIG8YBa64xYJOzq0OhLcumR88bxI=; b=abLFieHtWjxuHfoEtnWx6wvJ9RxkUdbaUud53LMW0OYeOtnY1Y+EWzBUzWuPPtgReQ 6OLjW09thZxUD04QeCwd/tPZ4Wlr12tav85ottHUGSUaTlFk3ehsl67CC1U2y7eTvZWS cUtVmzhZyedu4aZy+GBqIvuOaN4WRJGgJ7KNavudEaSeUeN0ABoRukYwlDJdSjKITiTf LLBIdWAuCn4jabck8SDT5J4zj8nOih0DS3IiS+8jLaMmYD8z8S7wtk4QJl5mHHD9VXBm khd+PoWb4KdUmk6VAOJ8e3FjwXCGOaH4YIg+FNMnuV7hUDGJMX7+Z4tjqRYrcobv94lo KtpQ== X-Gm-Message-State: APjAAAXT4o6/dn6bY8W5d55T/QSDG2SZNIelAGgryviYnFenZW1BmR3n WJWf1g7FQLFwLS22c2nz8rL+3g== X-Google-Smtp-Source: APXvYqwU+nrkVMviQ0KfOJOSSqvrS6c+64XorYFt0hgMbPGKlysmTWz0rBdcgaK8FsVS+utu2L464A== X-Received: by 2002:a63:f447:: with SMTP id p7mr1187912pgk.326.1582678551946; Tue, 25 Feb 2020 16:55:51 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f1sm272765pjq.31.2020.02.25.16.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 16:55:51 -0800 (PST) Date: Tue, 25 Feb 2020 16:55:41 -0800 From: Stephen Hemminger To: Olivier Matz Cc: Somnath Kotur , dev , Ferruh Yigit Message-ID: <20200225165541.01c06952@hermes.lan> In-Reply-To: <20200207142959.GR22738@platinum> References: <20200106083423.26600-1-somnath.kotur@broadcom.com> <20200206172500.GQ22738@platinum> <20200207142959.GR22738@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 7 Feb 2020 15:29:59 +0100 Olivier Matz wrote: > The meaning of each flag should be as simple as possible, I think we can > summarize them like this: > > - PKT_RX_VLAN: the vlan is saved in vlan tci. > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data. > - PKT_RX_QINQ: the outer vlan is saved in vlan tci. > - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data. > - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan > of initial packet, else it refers to the first vlan of the packet. > > There is a link between vlan flag and vlan_tci field, and qinq flag and > vlan_tci_outer field. > > I'm still not sure to understand what you expect. Can you give an > example with flags (which are set), and the expected content of m->vlan_tci > and m->vlan_tci_outer? > > By the way, the case 5/ is not very well described too, maybe we should > add something about it. > > Thanks, > Olivier The patch does help clarify the meaning, and Oliver's summary clarifies even more. It might be possible for hardware to offload inner vlan but not outer vlan, though seriously doubt anyone but some conformance test would do that.