From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01E5FA055A;
	Wed, 26 Feb 2020 14:45:57 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A10E21BFAB;
	Wed, 26 Feb 2020 14:45:57 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 34F721C01
 for <dev@dpdk.org>; Wed, 26 Feb 2020 14:45:56 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Feb 2020 05:45:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,488,1574150400"; d="scan'208";a="241670177"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17])
 by orsmga006.jf.intel.com with ESMTP; 26 Feb 2020 05:45:52 -0800
Date: Wed, 26 Feb 2020 21:43:55 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Sivaprasad Tummala <Sivaprasad.Tummala@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,
 Tomasz Kantecki <tomasz.kantecki@intel.com>,
 Sunil Kumar Kori <skori@marvell.com>,
 Pavan Nikhilesh <pbhagavatula@marvell.com>, dev <dev@dpdk.org>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <20200226134355.GC105977@intel.com>
References: <20200226091501.27967-1-Sivaprasad.Tummala@intel.com>
 <CAJFAV8yFsFXfvGzqzBsx42ttmEj-tmKYg935Xcj8O_z8GnsXyw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8yFsFXfvGzqzBsx42ttmEj-tmKYg935Xcj8O_z8GnsXyw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v1] examples/l2fwd: add check for promiscuous
 no support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, David

On 02/26, David Marchand wrote:
>On Wed, Feb 26, 2020 at 10:15 AM Sivaprasad Tummala
><Sivaprasad.Tummala@intel.com> wrote:
>>
>> l2fwd application exits, if return for rte_eth_promiscuous_enable
>> is not success. But for vHost PMD, promiscuous enable returns "Not
>> Supported".
>
>Could the vhost pmd announce that it is already in promiscuous mode?
>Like in f165210321c4 ("drivers/net: enable promiscuous and multicast
>by default")

I think it makes sense, I don't see any risk of doing it. I'll cook a patch
for it soon.

Thanks,
Xiaolong

>
>
>-- 
>David Marchand
>