Re: [dpdk-dev] [PATCH] net/ixgbe: fix issue for change definitions of bool

[Ye Xiaolong <xiaolong.ye@intel.com>]

Hi, Wei

On 02/27, Wei Zhao wrote:
>We had better not to change code in base folder, that patch will
>introduce a bug for etag/etag_strip for x550 NIC. So change back

Could you elaborate the details of this bug?

Thanks,
Xiaolong

>to the aboriginal definition.
>
>Cc: stable@dpdk.org
>Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool")
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ixgbe/base/ixgbe_osdep.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h
>index 844d1701f..19ce2d1c8 100644
>--- a/drivers/net/ixgbe/base/ixgbe_osdep.h
>+++ b/drivers/net/ixgbe/base/ixgbe_osdep.h
>@@ -9,7 +9,6 @@
> #include <stdint.h>
> #include <stdio.h>
> #include <stdarg.h>
>-#include <stdbool.h>
> #include <rte_common.h>
> #include <rte_debug.h>
> #include <rte_cycles.h>
>@@ -84,6 +83,10 @@ typedef uint32_t	u32;
> typedef int32_t		s32;
> typedef uint64_t	u64;
> 
>+#ifndef __cplusplus
>+typedef int		bool;
>+#endif
>+
> #define mb()	rte_mb()
> #define wmb()	rte_wmb()
> #define rmb()	rte_rmb()
>-- 
>2.17.1
>