From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3314EA055A; Thu, 27 Feb 2020 02:59:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B5B61BFAB; Thu, 27 Feb 2020 02:59:13 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 517BC1BF8D; Thu, 27 Feb 2020 02:59:11 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 17:59:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,490,1574150400"; d="scan'208";a="271980680" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 26 Feb 2020 17:59:08 -0800 Date: Thu, 27 Feb 2020 09:57:11 +0800 From: Ye Xiaolong To: Wei Zhao Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200227015711.GD105977@intel.com> References: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix issue for change definitions of bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Wei On 02/27, Wei Zhao wrote: >We had better not to change code in base folder, that patch will >introduce a bug for etag/etag_strip for x550 NIC. So change back Could you elaborate the details of this bug? Thanks, Xiaolong >to the aboriginal definition. > >Cc: stable@dpdk.org >Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool") > >Signed-off-by: Wei Zhao >--- > drivers/net/ixgbe/base/ixgbe_osdep.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h >index 844d1701f..19ce2d1c8 100644 >--- a/drivers/net/ixgbe/base/ixgbe_osdep.h >+++ b/drivers/net/ixgbe/base/ixgbe_osdep.h >@@ -9,7 +9,6 @@ > #include > #include > #include >-#include > #include > #include > #include >@@ -84,6 +83,10 @@ typedef uint32_t u32; > typedef int32_t s32; > typedef uint64_t u64; > >+#ifndef __cplusplus >+typedef int bool; >+#endif >+ > #define mb() rte_mb() > #define wmb() rte_wmb() > #define rmb() rte_rmb() >-- >2.17.1 >