DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dey, Souvik" <sodey@rbbn.com>
To: rmody@marvell.com, shshaikh@marvell.com, jerinj@marvell.com,
	ferruh.yigit@intel.com, thomas@monjalon.net
Cc: dev@dpdk.org, stable@dpdk.org, "Dey, Souvik" <sodey@rbbn.com>
Subject: [dpdk-dev] [PATCH v2] bnx2x: handle guest vlan for SR-IOV case
Date: Fri, 28 Feb 2020 14:48:23 -0500	[thread overview]
Message-ID: <20200228194823.14992-1-sodey@rbbn.com> (raw)
In-Reply-To: <20200226163635.18252-1-sodey@rbbn.com>

In case of bnx2xvf pmd, tx packets can support vland id in 2 ways :
1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the
vlanid in mbuf->vlan_tci.
2. the tx packet itself has the vlan id included in the packet.
The first case is working as expected but the second case where
the vlan id is included in thetx packets itself was found not
working as expected. To handle that we need to properly set the
start_bd bitfield and the vlan_or_ethertype instead of setting it
to just the ethertype in case of VF.


Signed-off-by: "Dey, Souvik" <sodey@rbbn.com>
---
v2:
 * Fix compilation issues.
   ether_type to rte_ether_type/
   ETHER_TYPE_VLAN to RTE_ETHER_TYPE_VLAN/
   vlan_hdr to rte_vlan_hdr/
 * Kept the Subject still same for refernce.

 drivers/net/bnx2x/bnx2x.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 0b4030e..6113d7c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -2216,11 +2216,23 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0)
 			tx_start_bd->vlan_or_ethertype =
 			    rte_cpu_to_le_16(pkt_prod);
 		else {
+			/* when transmitting in a vf, start bd must hold the ethertype
+			 * for fw to enforce it
+			 */
 			struct rte_ether_hdr *eh =
 			    rte_pktmbuf_mtod(m0, struct rte_ether_hdr *);
-
-			tx_start_bd->vlan_or_ethertype =
-			    rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
+			/* Still need to consider inband vlan for enforced */
+			if (eh->ether_type == rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) {
+				struct rte_vlan_hdr *vh = (struct vlan_hdr *)(eh + 1);
+				tx_start_bd->bd_flags.as_bitfield |=
+					(X_ETH_INBAND_VLAN <<
+						ETH_TX_BD_FLAGS_VLAN_MODE_SHIFT);
+				tx_start_bd->vlan_or_ethertype =
+					rte_cpu_to_le_16(ntohs(vh->vlan_tci));
+			} esle {
+				tx_start_bd->vlan_or_ethertype = (rte_cpu_to_le_16
+					(rte_be_to_cpu_16(eh->ether_type)));
+			}
 		}
 	}
 
-- 
2.9.3


-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.  Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly prohibited.  If you are not the intended
recipient, please notify the sender immediately and then delete all copies, including any attachments.
-----------------------------------------------------------------------------------------------------------------------

  parent reply	other threads:[~2020-02-28 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 16:36 [dpdk-dev] [PATCH] " Dey, Souvik
2020-02-26 23:05 ` [dpdk-dev] [EXT] " Rasesh Mody
2020-02-28 18:28 ` [dpdk-dev] [PATCH v2] net/bnx2x: " Dey, Souvik
2020-02-28 19:48 ` Dey, Souvik [this message]
2020-04-13 23:09 ` [dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN " Rasesh Mody
2020-04-14 13:46   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200228194823.14992-1-sodey@rbbn.com \
    --to=sodey@rbbn.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=rmody@marvell.com \
    --cc=shshaikh@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).