From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A776AA0565; Mon, 2 Mar 2020 03:22:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B61021BE83; Mon, 2 Mar 2020 03:22:28 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 842DD1BE81; Mon, 2 Mar 2020 03:22:27 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2020 18:22:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,506,1574150400"; d="scan'208";a="243040766" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga006.jf.intel.com with ESMTP; 01 Mar 2020 18:22:24 -0800 Date: Mon, 2 Mar 2020 10:20:16 +0800 From: Ye Xiaolong To: Xiao Zhang Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com, stable@dpdk.org Message-ID: <20200302022016.GB42796@intel.com> References: <1582860124-48237-1-git-send-email-xiao.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582860124-48237-1-git-send-email-xiao.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/28, Xiao Zhang wrote: >Return ENOTSUP error code when configuring i40evf promiscuous mode to >fix port start hang issue on platforms which are unsupported to configure >promiscuous mode. > >Fixes: ddc7cb0d9453 ("net/i40e: re-program promiscuous mode on VF >interface") Please don't truncate the Fixes tag line, otherwise check-git-log.sh will complain. >Cc: stable@dpdk.org > >Signed-off-by: Xiao Zhang >--- > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c >index c34f520..244397e 100644 >--- a/drivers/net/i40e/i40e_ethdev_vf.c >+++ b/drivers/net/i40e/i40e_ethdev_vf.c >@@ -2191,6 +2191,8 @@ i40evf_dev_promiscuous_enable(struct rte_eth_dev *dev) > ret = i40evf_config_promisc(dev, 1, vf->promisc_multicast_enabled); > if (ret == 0) > vf->promisc_unicast_enabled = TRUE; >+ else if (ret == I40E_NOT_SUPPORTED) >+ ret = -ENOTSUP; > else > ret = -EAGAIN; > >@@ -2206,6 +2208,8 @@ i40evf_dev_promiscuous_disable(struct rte_eth_dev *dev) > ret = i40evf_config_promisc(dev, 0, vf->promisc_multicast_enabled); > if (ret == 0) > vf->promisc_unicast_enabled = FALSE; >+ else if (ret == I40E_NOT_SUPPORTED) >+ ret = -ENOTSUP; > else > ret = -EAGAIN; > >@@ -2221,6 +2225,8 @@ i40evf_dev_allmulticast_enable(struct rte_eth_dev *dev) > ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 1); > if (ret == 0) > vf->promisc_multicast_enabled = TRUE; >+ else if (ret == I40E_NOT_SUPPORTED) >+ ret = -ENOTSUP; > else > ret = -EAGAIN; > >@@ -2236,6 +2242,8 @@ i40evf_dev_allmulticast_disable(struct rte_eth_dev *dev) > ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 0); > if (ret == 0) > vf->promisc_multicast_enabled = FALSE; >+ else if (ret == I40E_NOT_SUPPORTED) >+ ret = -ENOTSUP; > else > ret = -EAGAIN; > >-- >2.7.4 > For the rest, Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel with the Fixes line fix, Thanks.