DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/vhost: fix potential memory leak
@ 2020-03-03  0:03 Itsuro Oda
  2020-03-05  2:15 ` Ye Xiaolong
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Itsuro Oda @ 2020-03-03  0:03 UTC (permalink / raw)
  To: maxime.coquelin, tiwei.bie, zhihong.wang, anatoly.burakov, dev

If a vhost device is closed before eth_dev_configure is done
to the device, internal resources allocated to the device
does not freed. This patch fixes it.

Fixes: 3d01b759d267 ("net/vhost: delay driver setup")

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 drivers/net/vhost/rte_eth_vhost.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 458ed58f5..1ed977e9b 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1065,16 +1065,14 @@ eth_dev_close(struct rte_eth_dev *dev)
 
 	eth_dev_stop(dev);
 
-	rte_vhost_driver_unregister(internal->iface_name);
-
 	list = find_internal_resource(internal->iface_name);
-	if (!list)
-		return;
-
-	pthread_mutex_lock(&internal_list_lock);
-	TAILQ_REMOVE(&internal_list, list, next);
-	pthread_mutex_unlock(&internal_list_lock);
-	rte_free(list);
+	if (list) {
+		rte_vhost_driver_unregister(internal->iface_name);
+		pthread_mutex_lock(&internal_list_lock);
+		TAILQ_REMOVE(&internal_list, list, next);
+		pthread_mutex_unlock(&internal_list_lock);
+		rte_free(list);
+	}
 
 	if (dev->data->rx_queues)
 		for (i = 0; i < dev->data->nb_rx_queues; i++)
-- 
2.17.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-04-10 14:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03  0:03 [dpdk-dev] [PATCH] net/vhost: fix potential memory leak Itsuro Oda
2020-03-05  2:15 ` Ye Xiaolong
2020-03-05  2:50 ` [dpdk-dev] [PATCH v2] " Itsuro Oda
2020-03-05  2:54 ` [dpdk-dev] [PATCH v3] " Itsuro Oda
2020-03-19 17:15   ` Kevin Traynor
2020-03-20 16:23     ` Maxime Coquelin
2020-03-20 19:25       ` Kevin Traynor
2020-04-10 14:44   ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).