From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BB90A056D; Tue, 3 Mar 2020 03:55:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CDCA1BFF0; Tue, 3 Mar 2020 03:55:38 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D2B481BFEF; Tue, 3 Mar 2020 03:55:36 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 18:55:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,509,1574150400"; d="scan'208";a="412581249" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga005.jf.intel.com with ESMTP; 02 Mar 2020 18:55:33 -0800 Date: Tue, 3 Mar 2020 10:53:23 +0800 From: Ye Xiaolong To: "Zhang, Xiao" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" Message-ID: <20200303025323.GE25927@intel.com> References: <1582860124-48237-1-git-send-email-xiao.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/03, Zhang, Xiao wrote: >Hi Ferruh, > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, March 2, 2020 5:09 PM >> To: Zhang, Xiao ; dev@dpdk.org >> Cc: Xing, Beilei ; Zhang, Qi Z ; >> stable@dpdk.org >> Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check >> >> On 2/28/2020 3:22 AM, Xiao Zhang wrote: >> > Return ENOTSUP error code when configuring i40evf promiscuous mode to >> > fix port start hang issue on platforms which are unsupported to >> > configure promiscuous mode. >> >> Hi Xiao, >> >> What is the cause of the hang, was the application keep trying because of the "- >> EAGAIN" error? > >When starting port, rte_eth_dev_start will call rte_eth_dev_config_restore in which promisc configure will be called to enable/disable promiscuous mode. >Since "-EAGAIN" was returned if platforms not supported to configure promisc mode, it would return error and stop port starting. So the real issue caused by this is "Fail to start port", not "hang", right? I can change the description in the commit log directly. Thanks, Xiaolong