* [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop
@ 2020-02-26 9:22 Qiming Yang
2020-03-03 1:56 ` Ye Xiaolong
2020-03-03 5:45 ` [dpdk-dev] [PATCH v2] " Qiming Yang
0 siblings, 2 replies; 4+ messages in thread
From: Qiming Yang @ 2020-02-26 9:22 UTC (permalink / raw)
To: dev; +Cc: Qiming Yang, stable
GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be
called. This is the root cause of performance drop. This patch add support
for:
Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK
Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9fbda1c..c09b9b9 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
--
2.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop
2020-02-26 9:22 [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop Qiming Yang
@ 2020-03-03 1:56 ` Ye Xiaolong
2020-03-03 5:45 ` [dpdk-dev] [PATCH v2] " Qiming Yang
1 sibling, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2020-03-03 1:56 UTC (permalink / raw)
To: Qiming Yang; +Cc: dev, stable
Hi, Qiming
On 02/26, Qiming Yang wrote:
>GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be
>called. This is the root cause of performance drop. This patch add support
>for:
Could you elaborate what kind of performance drop caused by the missing register
cfg?
Thanks,
Xiaolong
>
> Device-ID Value Comments
> 0x37D0 0x03030303 4x10G FPK
>
>Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 9fbda1c..c09b9b9 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
>+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
>
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
>--
>2.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] net/i40e: fix X722 performance drop
2020-02-26 9:22 [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop Qiming Yang
2020-03-03 1:56 ` Ye Xiaolong
@ 2020-03-03 5:45 ` Qiming Yang
2020-03-03 6:14 ` Ye Xiaolong
1 sibling, 1 reply; 4+ messages in thread
From: Qiming Yang @ 2020-03-03 5:45 UTC (permalink / raw)
To: dev; +Cc: xiaolong.ye, Qiming Yang, stable
Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't
reach line rate in one queue one core forwarding case. It's about 1%
performance drop. This patch add value as:
Device-ID Value Comments
0x37D0 0x03030303 4x10G FPK
This value is hardware specific.
Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9fbda1c..c09b9b9 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
--
2.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/i40e: fix X722 performance drop
2020-03-03 5:45 ` [dpdk-dev] [PATCH v2] " Qiming Yang
@ 2020-03-03 6:14 ` Ye Xiaolong
0 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2020-03-03 6:14 UTC (permalink / raw)
To: Qiming Yang; +Cc: dev, stable
On 03/03, Qiming Yang wrote:
>Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't
>reach line rate in one queue one core forwarding case. It's about 1%
>performance drop. This patch add value as:
>
> Device-ID Value Comments
> 0x37D0 0x03030303 4x10G FPK
>
>This value is hardware specific.
>
>Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 9fbda1c..c09b9b9 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
> { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
>+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
>
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
> { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
>--
>2.9.5
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-03 6:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 9:22 [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop Qiming Yang
2020-03-03 1:56 ` Ye Xiaolong
2020-03-03 5:45 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2020-03-03 6:14 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).