From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21387A0572; Tue, 3 Mar 2020 19:16:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B16F21BFF4; Tue, 3 Mar 2020 19:16:20 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id CA0D01BFDD for ; Tue, 3 Mar 2020 19:16:19 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id f5so1862235pfk.9 for ; Tue, 03 Mar 2020 10:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RxpZGY5P2vzTy/AarjGcYpvYl45kkoQz/IhDHvxLSzM=; b=D1krf/YF8KbwmodAAlEvchpqEo9zCzcU21BhGas6MO9NCwTYbHfKQlmcrkyzUVhDQa GqWx84Drva1QmACMTzWRFadLbmetsdoA106YnwbiSueMheDgCwxsidzqbij7DzpDet6c ODbbfeCwnLTU81zFAmwfpG51sQ0G+fIK/ZEVHQRcyoD/942VddhUrnPpfATYAIzPsd1N LPquN7eG/yBmMaLAC7Ccea/xfIy/4XRh43quZWocqxqWXjOTZ7ZNpaLq42I7RiMau5U7 CQsEgmERQEg9eO9uZdQVFnp9n6RK9OB9+ZgqWlqyYrFD0cvAzOHyxdPsW1M/esmsAF4x sCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RxpZGY5P2vzTy/AarjGcYpvYl45kkoQz/IhDHvxLSzM=; b=nxsfYUkIs1Siowj1L9samyz/wDZ3E34UX2p1oAIvl7/E0Y297Jhdc8wqRygx8a+y77 p0tyb9EK1KZs5BWgCyy3PNhN+vlzbWQTTZF0SCk0l/WS858HRA3CK/jHj5i/sqJzcY+A 3+berVzGSLPy0UehxO4hO3DmN4ZT+2YKmTe0Ufdq4/A9X16ACjzeuWyVmo0m+1tbwyG7 NgUF0z13CHpBOBgVB+/4YByGGp/JOmsNd6Oj5Db/+OBzhyIKMmauqVkTaHd5dcC02fch QG2Vs7j+NY1YvOqGBPF9/zZbAG5lZ05V5QYbINO8sUEAbCeCpuN+FTeG360rkvea9Gdy JFBg== X-Gm-Message-State: ANhLgQ02kGq7CaK5bI0N+lq4HWKbFsdGfAJhtNJoPQE7i3AYMc1R71gF YHqfbIZukmQSFIDfGsdvAtkAgw== X-Google-Smtp-Source: ADFU+vsyC3pqtH5oJT+sB2OHX65XUFnShlYYk6RK6HNlzlHmtt+GWAnRWNW1e1WQi1hcr0nhzvZN8Q== X-Received: by 2002:a63:e04d:: with SMTP id n13mr5120563pgj.396.1583259378807; Tue, 03 Mar 2020 10:16:18 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u14sm7618216pgg.67.2020.03.03.10.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 10:16:18 -0800 (PST) Date: Tue, 3 Mar 2020 10:16:15 -0800 From: Stephen Hemminger To: Christopher Ertl Cc: Ajit Kumar Khaparde , "somnath.kotur@broadcom.com" , "dev@dpdk.org" Message-ID: <20200303101615.1fb56322@hermes.lan> In-Reply-To: References: <20200303175938.14292-1-stephen@networkplumber.org> <20200303175938.14292-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH 2/6] net/bnxt: fix potential data race X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 3 Mar 2020 18:13:22 +0000 Christopher Ertl wrote: > Can we add the `volatile` qualifier to the `hwrm_cmd_resp_addr` member (i= n drivers/net/bnxt/bnxt.h) to get a stronger guarantee that the compiler wo= n't insert TOCTOU races in the output? >=20 > Christopher Ertl | MSRC Vulnerabilities & Mitigations | Microsoft Limited= | +44 7773976589 | Christopher.Ertl@microsoft.com > =C2=A0 > Microsoft Limited (company number 01624297) is a company registered in En= gland and Wales whose registered office is at Microsoft Campus, Thames Vall= ey Park, Reading. RG6 1WG Should this be done for all the registers in that structure?