From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E3FCA056D; Tue, 3 Mar 2020 12:17:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 361261BFF4; Tue, 3 Mar 2020 12:17:15 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F3FE61BFE9; Tue, 3 Mar 2020 12:17:11 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 03:17:09 -0800 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="233587242" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.49]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Mar 2020 03:17:08 -0800 Date: Tue, 3 Mar 2020 11:17:05 +0000 From: Bruce Richardson To: Amit Gupta Cc: Harman Kalra , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20200303111705.GA1557@bricha3-MOBL.ger.corp.intel.com> References: <1581925669-15294-1-git-send-email-agupta3@marvell.com> <1583130716-28360-1-git-send-email-agupta3@marvell.com> <20200302105313.GA1603@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 03, 2020 at 03:10:56AM +0000, Amit Gupta wrote: > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Monday, March 2, 2020 4:23 PM > > To: Amit Gupta > > Cc: Harman Kalra ; dev@dpdk.org; stable@dpdk.org > > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build > > for disabled octeontx drivers > > > > External Email > > > > ---------------------------------------------------------------------- > > On Mon, Mar 02, 2020 at 12:01:55PM +0530, agupta3@marvell.com wrote: > > > From: Amit Gupta > > > > > > Add a additional condition to check if all required internal > > > dependencies are met before building octeontx drivers using meson. > > > > > > Bugzilla ID: 387 > > > > > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson") > > > > > > Signed-off-by: Amit Gupta > > > --- > > > v2: > > > - rebased to v20.02 > > > - upstream comments incorporated. > > > > > > drivers/net/octeontx/base/meson.build | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/octeontx/base/meson.build > > > b/drivers/net/octeontx/base/meson.build > > > index a06a2c8..035aeda 100644 > > > --- a/drivers/net/octeontx/base/meson.build > > > +++ b/drivers/net/octeontx/base/meson.build > > > @@ -10,7 +10,11 @@ sources = [ > > > depends = ['ethdev', 'mempool_octeontx'] static_objs = [] foreach > > > d: depends > > > - static_objs += [get_variable('static_rte_' + d)] > > > + test_dep_obj = '@0@'.format(get_variable('static_rte_' + d, '')) > > > + if test_dep_obj == '' > > > + subdir_done() > > > + endif > > > + static_objs += get_variable('static_rte_' + d) > > > endforeach > > > > very minor nit - you can use "test_dep_obj" here rather than calling > > get_variable twice. > > > test_dep_obj is being formatted as string object, so can't be used as static obj.. Apologies, you are quite right, I missed that. One final suggestion - the "is_variable" function is probably want you want rather than using get_variable with a fallback. It should save the use of a temporary variable completely. /Bruce