From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF4FFA0573; Wed, 4 Mar 2020 18:34:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 814111BFAB; Wed, 4 Mar 2020 18:34:09 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id C53951BFAA for ; Wed, 4 Mar 2020 18:34:08 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id q9so1302224pfs.5 for ; Wed, 04 Mar 2020 09:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EhhW3koxn3Ravl0C46mS0F/z8SLtFJNYdYIsAg2Z6G8=; b=UjdPzfxkdTozfQiwRnyHwKlIrVKcBNRofkbPRgK1tW5OjyZSt2cGT7Dgc/Fxjgh400 KIJxUuvOaeqtTOlLz8J7Xrc5w88LjlH77V9b6/3pS0q65XmjqMLG82u90wEmRX2bn+N8 4FHG19EiuIUlE8Gv2XQAeWNER/hNCtOzLENm6X9sfpmbqSTQASCVuNjp80FBEuvls/bC BFXETPRxoKrbj2gY5IraTDge0y2OwI1GQBiPXtmmkjxc7ASlGGKX9GGt4QVTHHd72/6z EyhJowKefnaNZhg+doG5Wvjzl8nDvvtueoi5Xjdpg9alS4hQxkSuDyly2cV4SgTFYXxL VRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EhhW3koxn3Ravl0C46mS0F/z8SLtFJNYdYIsAg2Z6G8=; b=e1Zs1mTOk2zunJAiNOZXXiYv4r0OzJNx/MPfti9BX/TTZ4bA1DIle9885AOfITQh8R NsPT8cbyPK2dxsaPmEfD+zQ2YhFvasHmw7ce/aW9j6qDQDxuKmPEKrNpJvKxXLruszL0 rCzCdCRFXCcqjI8BZSNghaVB3Sq4oYkXgXTAUrsOXNxtKzvc34nAeKfohpGMt+1kXxeu XjP07RFHsUBD1SDj1sjYATaDKmEW0TABuzTTFyhpjtFajr27RJwD0ux5btzZBMa5ztOR A/u+zbY0w0UDq5uNY29WQg0qFjse2e5Yf2jxDTFtMgXOxXwiS93zLOq7zTppN1Ksbk9x 6ppg== X-Gm-Message-State: ANhLgQ3mmqj0YS7gJeoeiCRpc8TLGhEfoJoPQmkWBKGHlsUivuMOVmVZ o6HO1A3vFKXsPWMrlWC6au0= X-Google-Smtp-Source: ADFU+vtt+HHRUKr7MuPioCWoME8eQ65I7Lbk0PjicbM5vb+/D5tzFk3D2VkK6ln/n9IGYg2Hyukq0A== X-Received: by 2002:a63:f752:: with SMTP id f18mr3534976pgk.196.1583343247996; Wed, 04 Mar 2020 09:34:07 -0800 (PST) Received: from localhost.localdomain ([124.156.211.233]) by smtp.gmail.com with ESMTPSA id r3sm22348675pfq.126.2020.03.04.09.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 09:34:07 -0800 (PST) From: ZY Qiu X-Google-Original-From: ZY Qiu To: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, ZY Qiu Date: Thu, 5 Mar 2020 01:33:49 +0800 Message-Id: <20200304173349.26459-1-tgw_team@tencent.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200304140543.31612-1-tgw_team@tencent.com> References: <20200304140543.31612-1-tgw_team@tencent.com> Subject: [dpdk-dev] [PATCH v2] rte_ethdev: safer memory access by calling Rx callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When compiling with -O0, the compiler does not optimize two memory accesses into one. Leads to accessing a null pointer when queue post Rx burst callback removal while traffic is running. See rte_eth_tx_burst function. Signed-off-by: ZY Qiu --- lib/librte_ethdev/rte_ethdev.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index d1a593ad1..35eb580ff 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -4388,10 +4388,8 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id, rx_pkts, nb_pkts); #ifdef RTE_ETHDEV_RXTX_CALLBACKS - if (unlikely(dev->post_rx_burst_cbs[queue_id] != NULL)) { - struct rte_eth_rxtx_callback *cb = - dev->post_rx_burst_cbs[queue_id]; - + struct rte_eth_rxtx_callback *cb = dev->post_rx_burst_cbs[queue_id]; + if (unlikely(cb != NULL)) { do { nb_rx = cb->fn.rx(port_id, queue_id, rx_pkts, nb_rx, nb_pkts, cb->param); -- 2.17.1