From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Itsuro Oda <oda@valinux.co.jp>
Cc: maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, anatoly.burakov@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix potential memory leak
Date: Thu, 5 Mar 2020 10:15:56 +0800 [thread overview]
Message-ID: <20200305021556.GA10157@intel.com> (raw)
In-Reply-To: <20200303000329.823-1-oda@valinux.co.jp>
On 03/03, Itsuro Oda wrote:
>If a vhost device is closed before eth_dev_configure is done
>to the device, internal resources allocated to the device
>does not freed. This patch fixes it.
s/does not freed/would not be freed
>
>Fixes: 3d01b759d267 ("net/vhost: delay driver setup")
Cc: stable@dpdk.org
>
>Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
>---
> drivers/net/vhost/rte_eth_vhost.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
>index 458ed58f5..1ed977e9b 100644
>--- a/drivers/net/vhost/rte_eth_vhost.c
>+++ b/drivers/net/vhost/rte_eth_vhost.c
>@@ -1065,16 +1065,14 @@ eth_dev_close(struct rte_eth_dev *dev)
>
> eth_dev_stop(dev);
>
>- rte_vhost_driver_unregister(internal->iface_name);
>-
> list = find_internal_resource(internal->iface_name);
>- if (!list)
>- return;
>-
>- pthread_mutex_lock(&internal_list_lock);
>- TAILQ_REMOVE(&internal_list, list, next);
>- pthread_mutex_unlock(&internal_list_lock);
>- rte_free(list);
>+ if (list) {
>+ rte_vhost_driver_unregister(internal->iface_name);
>+ pthread_mutex_lock(&internal_list_lock);
>+ TAILQ_REMOVE(&internal_list, list, next);
>+ pthread_mutex_unlock(&internal_list_lock);
>+ rte_free(list);
>+ }
>
> if (dev->data->rx_queues)
> for (i = 0; i < dev->data->nb_rx_queues; i++)
>--
>2.17.0
>
For the rest,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2020-03-05 2:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 0:03 Itsuro Oda
2020-03-05 2:15 ` Ye Xiaolong [this message]
2020-03-05 2:50 ` [dpdk-dev] [PATCH v2] " Itsuro Oda
2020-03-05 2:54 ` [dpdk-dev] [PATCH v3] " Itsuro Oda
2020-03-19 17:15 ` Kevin Traynor
2020-03-20 16:23 ` Maxime Coquelin
2020-03-20 19:25 ` Kevin Traynor
2020-04-10 14:44 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305021556.GA10157@intel.com \
--to=xiaolong.ye@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=oda@valinux.co.jp \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).