From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A6C06A056A;
Thu, 5 Mar 2020 21:51:18 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D90772BB8;
Thu, 5 Mar 2020 21:51:17 +0100 (CET)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 3D9123B5
for <dev@dpdk.org>; Thu, 5 Mar 2020 21:51:16 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1583441475;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=8P2a3LrdKYCFFycj2iDkKT8gNkNU8jARV6X8fIJSLso=;
b=C4EKYfa6aNJj60i/6q73knqLxUqLlMDKW5c+lbe1yNmU1T55nz58QNwa2zQcZhWEgYKs/g
kaLqpIE9a0j9e0iePjziKk7B/Yv8ur4caxydxjVigoxzGghmZWkOcvYI9TONM+WkwkOz+3
7xI+/9EY/4cmWvLgAbZOZBbeh9gL5ts=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-151-qfsZ5sH7MSK0zT9iZg6p3Q-1; Thu, 05 Mar 2020 15:51:11 -0500
X-MC-Unique: qfsZ5sH7MSK0zT9iZg6p3Q-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
[10.5.11.12])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C78218FF666;
Thu, 5 Mar 2020 20:51:09 +0000 (UTC)
Received: from w520.home (ovpn-116-28.phx2.redhat.com [10.3.116.28])
by smtp.corp.redhat.com (Postfix) with ESMTP id B832260BE0;
Thu, 5 Mar 2020 20:51:08 +0000 (UTC)
Date: Thu, 5 Mar 2020 13:51:08 -0700
From: Alex Williamson <alex.williamson@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com,
thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com,
bruce.richardson@intel.com
Message-ID: <20200305135108.7b4b8a7f@w520.home>
In-Reply-To: <20200227183407.74a5c5b4.cohuck@redhat.com>
References: <158213716959.17090.8399427017403507114.stgit@gimli.home>
<158213845865.17090.13613582696110253458.stgit@gimli.home>
<20200227183407.74a5c5b4.cohuck@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Subject: Re: [dpdk-dev] [PATCH v2 4/7] vfio: Introduce VFIO_DEVICE_FEATURE
ioctl and first user
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, 27 Feb 2020 18:34:07 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> On Wed, 19 Feb 2020 11:54:18 -0700
> Alex Williamson <alex.williamson@redhat.com> wrote:
>
> > The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device
> > agnostic ioctl for setting, retrieving, and probing device features.
> > This implementation provides a 16-bit field for specifying a feature
> > index, where the data porition of the ioctl is determined by the
> > semantics for the given feature. Additional flag bits indicate the
> > direction and nature of the operation; SET indicates user data is
> > provided into the device feature, GET indicates the device feature is
> > written out into user data. The PROBE flag augments determining
> > whether the given feature is supported, and if provided, whether the
> > given operation on the feature is supported.
> >
> > The first user of this ioctl is for setting the vfio-pci VF token,
> > where the user provides a shared secret key (UUID) on a SR-IOV PF
> > device, which users must provide when opening associated VF devices.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > ---
> > drivers/vfio/pci/vfio_pci.c | 52 +++++++++++++++++++++++++++++++++++++++++++
> > include/uapi/linux/vfio.h | 37 +++++++++++++++++++++++++++++++
> > 2 files changed, 89 insertions(+)
> >
> > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> > index 8dd6ef9543ca..e4d5d26e5e71 100644
> > --- a/drivers/vfio/pci/vfio_pci.c
> > +++ b/drivers/vfio/pci/vfio_pci.c
> > @@ -1180,6 +1180,58 @@ static long vfio_pci_ioctl(void *device_data,
> >
> > return vfio_pci_ioeventfd(vdev, ioeventfd.offset,
> > ioeventfd.data, count, ioeventfd.fd);
> > + } else if (cmd == VFIO_DEVICE_FEATURE) {
> > + struct vfio_device_feature feature;
> > + uuid_t uuid;
> > +
> > + minsz = offsetofend(struct vfio_device_feature, flags);
> > +
> > + if (copy_from_user(&feature, (void __user *)arg, minsz))
> > + return -EFAULT;
> > +
> > + if (feature.argsz < minsz)
> > + return -EINVAL;
> > +
> > + if (feature.flags & ~(VFIO_DEVICE_FEATURE_MASK |
> > + VFIO_DEVICE_FEATURE_SET |
> > + VFIO_DEVICE_FEATURE_GET |
> > + VFIO_DEVICE_FEATURE_PROBE))
> > + return -EINVAL;
>
> GET|SET|PROBE is well-defined, but what about GET|SET without PROBE? Do
> we want to fence this in the generic ioctl handler part? Or is there
> any sane way to implement that (read and then write back something?)
I'd be ok with discouraging combinations of GET|SET|!PROBE generically.
I don't think there's an intuitive answer to whether it should be
applied as GET|SET or SET|GET. If some future feature wanted an atomic
op we could add something like a test-and-set. Thanks,
Alex
> > +
> > + switch (feature.flags & VFIO_DEVICE_FEATURE_MASK) {
> > + case VFIO_DEVICE_FEATURE_PCI_VF_TOKEN:
> > + if (!vdev->vf_token)
> > + return -ENOTTY;
> > +
> > + /*
> > + * We do not support GET of the VF Token UUID as this
> > + * could expose the token of the previous device user.
> > + */
> > + if (feature.flags & VFIO_DEVICE_FEATURE_GET)
> > + return -EINVAL;
> > +
> > + if (feature.flags & VFIO_DEVICE_FEATURE_PROBE)
> > + return 0;
> > +
> > + /* Don't SET unless told to do so */
> > + if (!(feature.flags & VFIO_DEVICE_FEATURE_SET))
> > + return -EINVAL;
> > +
> > + if (feature.argsz < minsz + sizeof(uuid))
> > + return -EINVAL;
> > +
> > + if (copy_from_user(&uuid, (void __user *)(arg + minsz),
> > + sizeof(uuid)))
> > + return -EFAULT;
> > +
> > + mutex_lock(&vdev->vf_token->lock);
> > + uuid_copy(&vdev->vf_token->uuid, &uuid);
> > + mutex_unlock(&vdev->vf_token->lock);
> > +
> > + return 0;
> > + default:
> > + return -ENOTTY;
> > + }
> > }
> >
> > return -ENOTTY;
> (...)