From: Xiaolong Ye <xiaolong.ye@intel.com>
To: maxime.coquelin@redhat.com, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment
Date: Sat, 7 Mar 2020 21:22:34 +0800 [thread overview]
Message-ID: <20200307132235.210168-2-xiaolong.ye@intel.com> (raw)
In-Reply-To: <20200307132235.210168-1-xiaolong.ye@intel.com>
Fix the comment that's incorrect as the code evolves.
Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
Cc: stable@dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index f9d0ea70d..35203940a 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
}
if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {
- PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2");
+ PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2");
return -EINVAL;
}
@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
hw->cvq = cvq;
}
- /* For virtio_user case (that is when hw->dev is NULL), we use
- * virtual address. And we need properly set _offset_, please see
+ /* For virtio_user case (that is when hw->virtio_user_dev is not NULL),
+ * we use virtual address. And we need properly set _offset_, please see
* VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.
*/
if (!hw->virtio_user_dev)
--
2.17.1
next prev parent reply other threads:[~2020-03-07 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 13:22 [dpdk-dev] [PATCH v1 0/2] small fixes Xiaolong Ye
2020-03-07 13:22 ` Xiaolong Ye [this message]
2020-04-09 14:20 ` [dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment Maxime Coquelin
2020-03-07 13:22 ` [dpdk-dev] [PATCH v1 2/2] vhost: remove unused variable Xiaolong Ye
2020-04-09 14:21 ` Maxime Coquelin
2020-04-10 14:44 ` [dpdk-dev] [PATCH v1 0/2] small fixes Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307132235.210168-2-xiaolong.ye@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).