From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E22EFA052E; Mon, 9 Mar 2020 16:40:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A3401C0B3; Mon, 9 Mar 2020 16:40:45 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 460C91C07E for ; Mon, 9 Mar 2020 16:40:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 08:40:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,533,1574150400"; d="scan'208";a="442789679" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga006.fm.intel.com with ESMTP; 09 Mar 2020 08:40:40 -0700 Date: Mon, 9 Mar 2020 23:38:13 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com Message-ID: <20200309153813.GC112283@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200309141437.11800-2-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309141437.11800-2-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/09, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >So if the DCF (Device Config Function) mode is specified by the devarg >'cap=dcf', then it will stop the PCI probe in the iavf PMD. > >Signed-off-by: Haiyue Wang >--- > drivers/net/iavf/iavf_ethdev.c | 41 ++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > >diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c >index 34913f9c4..8ff26c0e7 100644 >--- a/drivers/net/iavf/iavf_ethdev.c >+++ b/drivers/net/iavf/iavf_ethdev.c >@@ -1416,9 +1416,49 @@ iavf_dev_uninit(struct rte_eth_dev *dev) > return 0; > } > >+static int >+handle_dcf_arg(__rte_unused const char *key, const char *value, >+ __rte_unused void *arg) >+{ >+ bool *dcf = arg; >+ >+ if (arg == NULL || value == NULL) >+ return -EINVAL; >+ >+ if (strcmp(value, "dcf") == 0) >+ *dcf = true; >+ else >+ *dcf = false; >+ >+ return 0; >+} >+ >+static bool >+check_cap_dcf_enable(struct rte_devargs *devargs) >+{ >+ struct rte_kvargs *kvlist; >+ bool enable = false; >+ >+ if (devargs == NULL) >+ return false; >+ >+ kvlist = rte_kvargs_parse(devargs->args, NULL); >+ if (kvlist == NULL) >+ return false; >+ >+ rte_kvargs_process(kvlist, "cap", handle_dcf_arg, &enable); Need error handling for failure case. >+ >+ rte_kvargs_free(kvlist); >+ >+ return enable; >+} >+ > static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > struct rte_pci_device *pci_dev) > { >+ if (check_cap_dcf_enable(pci_dev->device.devargs)) >+ return 1; /* continue to probe */ This comment is confusing... >+ > return rte_eth_dev_pci_generic_probe(pci_dev, > sizeof(struct iavf_adapter), iavf_dev_init); > } >@@ -1439,6 +1479,7 @@ static struct rte_pci_driver rte_iavf_pmd = { > RTE_PMD_REGISTER_PCI(net_iavf, rte_iavf_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_iavf, pci_id_iavf_map); > RTE_PMD_REGISTER_KMOD_DEP(net_iavf, "* igb_uio | vfio-pci"); >+RTE_PMD_REGISTER_PARAM_STRING(net_iavf, "cap=dcf"); > RTE_INIT(iavf_init_log) > { > iavf_logtype_init = rte_log_register("pmd.net.iavf.init"); >-- >2.25.1 >