From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAFEFA052E; Mon, 9 Mar 2020 17:27:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D946B1C030; Mon, 9 Mar 2020 17:27:39 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1C5311BFF6 for ; Mon, 9 Mar 2020 17:27:37 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 09:27:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,533,1574150400"; d="scan'208";a="414861640" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga005.jf.intel.com with ESMTP; 09 Mar 2020 09:27:34 -0700 Date: Tue, 10 Mar 2020 00:25:07 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com Message-ID: <20200309162507.GE112283@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200309141437.11800-3-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309141437.11800-3-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/09, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >The DCF (Device Config Function) feature shares the core functions of >the ICE PMD, like it needs to export the DDP definition symbols for the >new DCF PMD use. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_ethdev.c | 9 +-------- > drivers/net/ice/ice_ethdev.h | 8 ++++++++ > 2 files changed, 9 insertions(+), 8 deletions(-) > >diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c >index b42deb0bc..8b9d211b0 100644 >--- a/drivers/net/ice/ice_ethdev.c >+++ b/drivers/net/ice/ice_ethdev.c >@@ -67,15 +67,8 @@ static struct proto_xtr_ol_flag ice_proto_xtr_ol_flag_params[] = { > > #define ICE_DFLT_OUTER_TAG_TYPE ICE_AQ_VSI_OUTER_TAG_VLAN_9100 > >-/* DDP package search path */ >-#define ICE_PKG_FILE_DEFAULT "/lib/firmware/intel/ice/ddp/ice.pkg" >-#define ICE_PKG_FILE_UPDATES "/lib/firmware/updates/intel/ice/ddp/ice.pkg" >-#define ICE_PKG_FILE_SEARCH_PATH_DEFAULT "/lib/firmware/intel/ice/ddp/" >-#define ICE_PKG_FILE_SEARCH_PATH_UPDATES "/lib/firmware/updates/intel/ice/ddp/" >- > #define ICE_OS_DEFAULT_PKG_NAME "ICE OS Default Package" > #define ICE_COMMS_PKG_NAME "ICE COMMS Package" >-#define ICE_MAX_PKG_FILENAME_SIZE 256 > #define ICE_MAX_RES_DESC_NUM 1024 > > int ice_logtype_init; >@@ -1833,7 +1826,7 @@ ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file) > return 0; > } > >-static enum ice_pkg_type >+enum ice_pkg_type > ice_load_pkg_type(struct ice_hw *hw) > { > enum ice_pkg_type package_type; >diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h >index da557a254..7b94a3c3e 100644 >--- a/drivers/net/ice/ice_ethdev.h >+++ b/drivers/net/ice/ice_ethdev.h >@@ -42,6 +42,13 @@ > > #define ICE_MAX_PKT_TYPE 1024 > >+/* DDP package search path */ >+#define ICE_PKG_FILE_DEFAULT "/lib/firmware/intel/ice/ddp/ice.pkg" >+#define ICE_PKG_FILE_UPDATES "/lib/firmware/updates/intel/ice/ddp/ice.pkg" >+#define ICE_PKG_FILE_SEARCH_PATH_DEFAULT "/lib/firmware/intel/ice/ddp/" >+#define ICE_PKG_FILE_SEARCH_PATH_UPDATES "/lib/firmware/updates/intel/ice/ddp/" >+#define ICE_MAX_PKG_FILENAME_SIZE 256 >+ > /** > * vlan_id is a 12 bit number. > * The VFTA array is actually a 4096 bit array, 128 of 32bit elements. >@@ -457,6 +464,7 @@ struct ice_vsi_vlan_pvid_info { > #define ICE_PF_TO_ETH_DEV(pf) \ > (((struct ice_pf *)pf)->adapter->eth_dev) > >+enum ice_pkg_type ice_load_pkg_type(struct ice_hw *hw); > struct ice_vsi * > ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type); > int >-- >2.25.1 > Acked-by: Xiaolong Ye