From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 285D4A0563; Tue, 10 Mar 2020 06:25:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17B041BFF5; Tue, 10 Mar 2020 06:25:46 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id AD7A01BF7F for ; Tue, 10 Mar 2020 06:25:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 22:25:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,535,1574150400"; d="scan'208";a="235819506" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga008.fm.intel.com with ESMTP; 09 Mar 2020 22:25:40 -0700 Date: Tue, 10 Mar 2020 13:23:11 +0800 From: Ye Xiaolong To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" , "Zhao1, Wei" Message-ID: <20200310052311.GB3098@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200309141437.11800-4-haiyue.wang@intel.com> <20200310041711.GA3098@intel.com> <4fec0ed259274d2ca7e0c183eb6d62d7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fec0ed259274d2ca7e0c183eb6d62d7@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/10, Wang, Haiyue wrote: >> >+static int >> >+ice_dcf_dev_filter_ctrl(struct rte_eth_dev *dev, >> >+ enum rte_filter_type filter_type, >> >+ __rte_unused enum rte_filter_op filter_op, >> >+ __rte_unused void *arg) >> >+{ >> >> legacy filter API will be deprecated, I think we should avoid adding support >> in new PMD. > >This is the entry for new filter: > >dev->dev_ops->filter_ctrl(dev, > RTE_ETH_FILTER_GENERIC, > RTE_ETH_FILTER_GET, > &ops) Right, I have some misunderstanding before, the filter API will be deprecated, but the dev->filter_ctrl ops is still needed. Thanks, Xiaolong