DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Muhammad Ahmad <muhammad.ahmad@emumba.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN
Date: Tue, 10 Mar 2020 08:18:06 -0700	[thread overview]
Message-ID: <20200310081806.3f955075@hermes.lan> (raw)
In-Reply-To: <20200310065036.4396-1-muhammad.ahmad@emumba.com>

On Tue, 10 Mar 2020 11:50:36 +0500
Muhammad Ahmad <muhammad.ahmad@emumba.com> wrote:

> Change the RTE_ETHER_MAX_LEN from 1518 to 1526
> 
> Bugzilla ID: 296
> 
> Fixes: c5b2d13 (net: add rte prefix to ether defines)
> 
> Cc: stable@dpdk.org
> Cc: Oliver Matz <olivier.matz@6wind.com>
> 
> Reported-by: LAVA <lavaraj@gmail.com>
> Suggested-by: LAVA <lavaraj@gmail.com>
> Signed-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com>
> ---
>  lib/librte_net/rte_ether.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> index e069dc7fe..8953107f3 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -30,7 +30,7 @@ extern "C" {
>  	(RTE_ETHER_ADDR_LEN * 2 + \
>  		RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */
>  #define RTE_ETHER_MIN_LEN   64    /**< Minimum frame len, including CRC. */
> -#define RTE_ETHER_MAX_LEN   1518  /**< Maximum frame len, including CRC. */
> +#define RTE_ETHER_MAX_LEN   1526  /**< Maximum frame len, including CRC. */
>  #define RTE_ETHER_MTU       \
>  	(RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \
>  		RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */

No that is abi change would impact a lot of code and drivers.
The problem is the comment is wrong, not the value.

      reply	other threads:[~2020-03-10 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  6:50 Muhammad Ahmad
2020-03-10 15:18 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310081806.3f955075@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=muhammad.ahmad@emumba.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).