From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9F169A0566;
Tue, 10 Mar 2020 16:18:17 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 82A1A1BFFB;
Tue, 10 Mar 2020 16:18:17 +0100 (CET)
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 32E9B1BFF5
for <dev@dpdk.org>; Tue, 10 Mar 2020 16:18:16 +0100 (CET)
Received: by mail-pg1-f194.google.com with SMTP id c7so712170pgw.3
for <dev@dpdk.org>; Tue, 10 Mar 2020 08:18:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=nzsuIDbxBQO7vopWQiqIHvypc7eu+B3vwVyuY6gSMUQ=;
b=sItYSjw1/scR1jsLGM8eHdoXS47z2g9nos+6zsDCx6nSpD8vu/VXDmxrgBqpWbXf+2
XmR5AvoxcGEjPtcmVoGh7vkHzBAapGzON6cKPgcLiKjXrVusOwSC5uuVyvndsHcAhYSt
AMMjb6FHbR0YqhXiU/HTQynE2CJDNugJXqW6xcGk8uF6btlZQZP/abpetgV7KKyH4uR6
L+DkrA/iceeNs6hNtj8poL4fTVxuwj0yCEDQjBokht0KczDw+lLOgyx1xEmnwhdLvXbZ
jwP4cQndIhQIwLUIuFvv7HAGFXuWXKoSo6AhWY7qgQcfKClJ4bHfaWXadfsmm2qJKjBk
5FuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=nzsuIDbxBQO7vopWQiqIHvypc7eu+B3vwVyuY6gSMUQ=;
b=ZcoXPzjJErn5Fw07mRa9h1D1ix7uNtZGRTf/VChF+iGh/CD3/T9PAh3sLy/jBuytp1
MYmZJ9aS+WumB/elDCzz7Wjra9ZuAG2M6oxR9L3zwIPgsG4/bqe9FQ3u15RH9oqDc5Tl
BmD9V1agQWYwZA90rxJybap536XcYNpSo8K43WlTwq+GAj3Ny4uELnZO7a4ZoWQlrUz4
C6SvvvvSckjH2pefVULUNmLqXKySm3r5d9A+0sntfwp9j9NeXso1uQnEEMx7RzPZdvNm
tSlnixOUwdBcODMFEj10a7Yc3ZXp7ID9tytveuaHCltLpfSOxJlk418uuB4Ojr1OzCu/
pSUw==
X-Gm-Message-State: ANhLgQ1KocTpRqgQ22tnQq/TA+MlfT71VApgysRG24He3CssKB2dpOQd
cvhaHxeRiCJnX8OqURJCbda8Fg==
X-Google-Smtp-Source: ADFU+vtWDHVxypohLL0IuVwg+g6UxPbkxUqqh/1xDBpAd6/I/Lpqg+xzXNKL+WdfERLp8EgwNI/81g==
X-Received: by 2002:a65:424a:: with SMTP id d10mr6939840pgq.84.1583853495252;
Tue, 10 Mar 2020 08:18:15 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id md20sm2717009pjb.15.2020.03.10.08.18.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 10 Mar 2020 08:18:14 -0700 (PDT)
Date: Tue, 10 Mar 2020 08:18:06 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Muhammad Ahmad <muhammad.ahmad@emumba.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org, stable@dpdk.org
Message-ID: <20200310081806.3f955075@hermes.lan>
In-Reply-To: <20200310065036.4396-1-muhammad.ahmad@emumba.com>
References: <20200310065036.4396-1-muhammad.ahmad@emumba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net/rte_ether.h:changed
RTE_ETHER_MAX_LEN
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, 10 Mar 2020 11:50:36 +0500
Muhammad Ahmad <muhammad.ahmad@emumba.com> wrote:
> Change the RTE_ETHER_MAX_LEN from 1518 to 1526
>
> Bugzilla ID: 296
>
> Fixes: c5b2d13 (net: add rte prefix to ether defines)
>
> Cc: stable@dpdk.org
> Cc: Oliver Matz <olivier.matz@6wind.com>
>
> Reported-by: LAVA <lavaraj@gmail.com>
> Suggested-by: LAVA <lavaraj@gmail.com>
> Signed-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com>
> ---
> lib/librte_net/rte_ether.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> index e069dc7fe..8953107f3 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -30,7 +30,7 @@ extern "C" {
> (RTE_ETHER_ADDR_LEN * 2 + \
> RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */
> #define RTE_ETHER_MIN_LEN 64 /**< Minimum frame len, including CRC. */
> -#define RTE_ETHER_MAX_LEN 1518 /**< Maximum frame len, including CRC. */
> +#define RTE_ETHER_MAX_LEN 1526 /**< Maximum frame len, including CRC. */
> #define RTE_ETHER_MTU \
> (RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \
> RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */
No that is abi change would impact a lot of code and drivers.
The problem is the comment is wrong, not the value.